Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jaeger-operator] update to 1.34.1 #367

Merged
merged 1 commit into from
Jun 7, 2022
Merged

[jaeger-operator] update to 1.34.1 #367

merged 1 commit into from
Jun 7, 2022

Conversation

czomo
Copy link
Contributor

@czomo czomo commented May 27, 2022 •
edited
Loading

Signed-off-by: czomo tomaszjdul@gmail.com

What this PR does

Updates jaeger-operator update to 1.34.1

Which issue this PR fixes

Checklist

  • DCO signed
  • Commits are GPG signed
  • Chart Version bumped
  • Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
  • README.md has been updated to match version/contain new values

@czomo czomo force-pushed the jaeger-operator-1-34-1 branch 3 times, most recently from 6a5c239 to 9f81e63 Compare May 27, 2022 14:05
@czomo
Copy link
Contributor Author

czomo commented May 27, 2022 •
edited
Loading

/hold
I noticed we missing something big. Looking at https://github.com/jaegertracing/jaeger-operator/pull/1864/files, jaeger-operator introduced another dependency. That's why multiple people complaining about complaining about missing certs(since 2.30.0 of this chart using appVersion:v1.31). There is no certificate manifest and so on, example https://github.com/jaegertracing/jaeger-operator/blob/faa5c70a09abc98170b9e175e76d72ef9a1764af/config/certmanager/certificate.yaml.

@cpanato Should we create separate PR or add it here? Wdyt?

@czomo czomo changed the title jaeger-operator update to 1.34.1 [jaeger-operator] update to 1.34.1 Jun 4, 2022
@avishefi avishefi mentioned this pull request Jun 6, 2022
Closed
@czomo
Bump jaeger-operator image to 1.34.1
90cced4 
Signed-off-by: czomo <tomaszjdul@gmail.com>
@czomo
Copy link
Contributor Author

czomo commented Jun 7, 2022

#368 is merged into main. Now we can bump the image FYI @cpanato @batazor

@czomo czomo requested a review from cpanato June 7, 2022 11:49
@batazor batazor merged commit 178b4a2 into jaegertracing:main Jun 7, 2022
@Nerkho Nerkho mentioned this pull request Jun 21, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batazor batazor Awaiting requested review from batazor batazor is a code owner

@cpanato cpanato Awaiting requested review from cpanato cpanato is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@czomo @cpanato @batazor