Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jaeger] feat: add option to add "envFrom" in deployments #387

Closed
wants to merge 1 commit into from
Closed

[jaeger] feat: add option to add "envFrom" in deployments #387

wants to merge 1 commit into from

Conversation

sedflix
Copy link

@sedflix sedflix commented Jul 21, 2022

What this PR does

This PR adds an option of giving "envFrom" to the deployment manifest.

Checklist

  • DCO signed
  • Commits are GPG signed
  • Chart Version bumped
  • Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
  • README.md has been updated to match version/contain new values (> not sure where to update new version in the readme)

@mehta-ankit
Copy link
Member

mehta-ankit commented Jul 21, 2022 •
edited
Loading

@sedflix the commit needs to be GPG signed. Can you do that please.

@sedflix sedflix force-pushed the main branch 2 times, most recently from c1b80e4 to 628e9f3 Compare July 21, 2022 13:43
@mehta-ankit
Copy link
Member

@sedflix can you resolve the conflicts and GPG sign the commit please.

@pavelnikolov
Copy link
Contributor

@sedflix ping

@pavelnikolov
Copy link
Contributor

@sedflix

Merging is blocked
The base branch requires all commits to be signed

pavelnikolov
pavelnikolov requested changes Mar 19, 2023
View reviewed changes
Copy link
Contributor

@pavelnikolov pavelnikolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, sign your commit.

@pavelnikolov
Copy link
Contributor

pavelnikolov commented May 23, 2023 •
edited
Loading

I don't understand why this keeps failing.
Screenshot 2023-05-23 at 11 15 39
I read the docs and it seems that it falls in this case.

@sedflix Could you, please, try to rebase locally and force push with a signed commit. Hopefully, that will resolve the problem.

@mehta-ankit
feat: add option to add "envFrom" in deployments
2c8911a 
bump chart version

Signed-off-by: Siddharth Yadav <siddharthy@zeta.tech>
(cherry picked from commit 628e9f3)
Signed-off-by: Ankit Mehta <ankit.mehta@appian.com>
@mehta-ankit mehta-ankit mentioned this pull request Jun 23, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelnikolov pavelnikolov pavelnikolov approved these changes

@mehta-ankit mehta-ankit mehta-ankit approved these changes

@naseemkullah naseemkullah naseemkullah approved these changes

@dvonthenen dvonthenen Awaiting requested review from dvonthenen dvonthenen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sedflix @mehta-ankit @pavelnikolov @naseemkullah