-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jaeger] Elasticsearch chart migration #554
Merged
pavelnikolov
merged 1 commit into
jaegertracing:main
from
dpericaxon:elasticsearch-chart-migration
Apr 17, 2024
Merged
[jaeger] Elasticsearch chart migration #554
pavelnikolov
merged 1 commit into
jaegertracing:main
from
dpericaxon:elasticsearch-chart-migration
Apr 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97b43ef
to
8d11c17
Compare
Hmm, not sure why that check is failing. It seems to render fine. It looks like its complaining about this line |
Could you, please, go through the PR checklist? |
@pavelnikolov all set! |
pavelnikolov
approved these changes
Apr 15, 2024
Are your commits gpg signed? |
583b80e
to
a77cd99
Compare
Is it possible to squash all the commits? |
Signed-off-by: dperic <108087612+dpericaxon@users.noreply.github.com> feat: Elasticsearch Bitnami Chart Migration to Support Elasticsearch 8 Signed-off-by: dperic <108087612+dpericaxon@users.noreply.github.com> feat: Elasticsearch Bitnami Chart Migration to Support Elasticsearch 8 Signed-off-by: dperic <108087612+dpericaxon@users.noreply.github.com> feat: Elasticsearch Bitnami Chart Migration to Support Elasticsearch 8 Signed-off-by: dperic <108087612+dpericaxon@users.noreply.github.com> feat: Elasticsearch Bitnami Chart Migration to Support Elasticsearch 8 Signed-off-by: dperic <108087612+dpericaxon@users.noreply.github.com> Revert Kafka version Signed-off-by: dperic <108087612+dpericaxon@users.noreply.github.com> quick lint test update Signed-off-by: dperic <108087612+dpericaxon@users.noreply.github.com> fix kubectl version Signed-off-by: dperic <108087612+dpericaxon@users.noreply.github.com> fix chart-testing versions Signed-off-by: dperic <108087612+dpericaxon@users.noreply.github.com>
a77cd99
to
5c52a7a
Compare
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR changes the Elasticsearch helm chart to https://github.com/bitnami/charts/tree/main/bitnami/elasticsearch to migrate to a supported helm chart since the current one is deprecated. I bumped the major version since the helm chart is getting changed.
I was able to get this to work with the default settings. Out of the box Elasticsearch doesn't have auth support unless
security.enabled
is set.To migrate existing workloads/data I was able to follow instructions on migrating the volumes to a new PVC thats created by the helm chart. This is similar to the Kafka migration that was done:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format,will close that issue when PR gets merged)
Checklist
[jaeger]
or[jaeger-operator]
)