Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jaeger] Added missing quotes to README.md #580

Closed
wants to merge 2 commits into from
Closed

[jaeger] Added missing quotes to README.md #580

wants to merge 2 commits into from

Conversation

Tomy8s
Copy link

@Tomy8s Tomy8s commented May 27, 2024 •
edited by pavelnikolov
Loading

What this PR does

Add missing quotes to extraObjects to fix invalid YAML in example in README.md

Checklist

  • DCO signed
  • Commits are GPG signed
  • Chart Version bumped
  • Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
  • README.md has been updated to match version/contain new values

@Tomy8s
Add missing quotes to extraObjects to fix invalid YAML in example i…
9d5d1fe 
…n README.md

Signed-off-by: Thomas Yates <tomy8s@hotmail.com>
@Tomy8s Tomy8s mentioned this pull request May 27, 2024
Open
@pavelnikolov
Copy link
Contributor

I tried to fix it here through the GitHub UI but I messed up the commit and couldn't rebase it. So I fixed it here instead.
Thank you!

@Tomy8s Tomy8s deleted the add-missing-readme-quotes branch May 28, 2024 13:27
@Tomy8s Tomy8s mentioned this pull request May 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvonthenen dvonthenen Awaiting requested review from dvonthenen dvonthenen is a code owner

@naseemkullah naseemkullah Awaiting requested review from naseemkullah naseemkullah is a code owner

@pavelnikolov pavelnikolov Awaiting requested review from pavelnikolov pavelnikolov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tomy8s @pavelnikolov