Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana dashboard for trace quality #22

Merged
merged 6 commits into from
Feb 5, 2020

Conversation

pavolloffay
Copy link
Member

@pavolloffay pavolloffay commented Feb 4, 2020

Resolves #16

@annanay25 could you please have a look?

Signed-off-by: Pavol Loffay ploffay@redhat.com

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Copy link
Member

@annanay25 annanay25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Makefile Outdated
.PHONY: grafana-run
grafana-run:
echo "Open browser on :3000"
docker run --rm -it --net=host grafana/grafana
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit: A config file and the dashboard.json can be mounted on the container directly!

Ref - https://grafana.com/docs/grafana/latest/administration/provisioning/#dashboards

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a config file for datasource and dashboards. In the tracequality dashboard I hardcoded datasource Prometheus. We can change this once we introduce mixins.

@@ -0,0 +1,476 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dashboard creation can be templated through the mixin (we can use it for future releases if dashboards get bigger)
Ref- jaegertracing/jaeger#1668

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 I think we could have more dashboards.

A dashboard I am thinking about would show other derived metrics from traces per service. We could also define alerts for these metrics.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if users would need alerts on these metrics, but definitely +1 for dashboards.

@pavolloffay
Copy link
Member Author

@annanay25 the dashboard has one configurable variable - service. Do you know if grafana can be configured to search possible values of this variable based on the Prometheus metric label?

Screenshot of Trace quality - Grafana (1)

@annanay25
Copy link
Member

Do you know if grafana can be configured to search possible values of this variable based on the Prometheus metric label?

@pavolloffay - Yes, this is definitely possible.
Something like $service = label_name("trace_quality_server_tag_total", "service") should do the trick.

References -
https://grafana.com/docs/grafana/latest/features/datasources/prometheus/#query-variable
https://banzaicloud.com/blog/grafana-templating/

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@pavolloffay
Copy link
Member Author

Am I doing something wrong? label_values("trace_quality_server_tag_total", "service") - I am interested to get values of the service label

Screenshot of Trace quality - Grafana (2)

@pavolloffay
Copy link
Member Author

label_values("service") didn't work for me either

@pavolloffay
Copy link
Member Author

I will merge this and create issue to populate label values to service dropdown.

@annanay25
Copy link
Member

Strange, I'll try getting it working on my local machine and get back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grafana dashboard for trace quality metrics
2 participants