Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

tracer.Inject(SpanContext&, HTTPHeadersWriter&) does not use HTTPHeaderPropagator #107

Closed
HugoMFernandes opened this issue May 15, 2018 · 1 comment
Closed

tracer.Inject(SpanContext&, HTTPHeadersWriter&) does not use HTTPHeaderPropagator #107

HugoMFernandes opened this issue May 15, 2018 · 1 comment

Comments

@HugoMFernandes
Copy link
Contributor

tracer.Inject(SpanContext&, HTTPHeadersWriter&) is currently using TextMapPropagator instead of HTTPHeaderPropagator.

Here's the bug:

jaeger-client-cpp/src/jaegertracing/Tracer.h

Line 151 in 75191fc

_textPropagator.inject(*jaegerCtx, writer);

I'm guessing this was a copy/paste problem (Tracer::Extract is fine). I'll create a PR with the fix in a second.
HugoMFernandes added a commit to HugoMFernandes/jaeger-client-cpp that referenced this issue May 15, 2018
@HugoMFernandes
Fix tracer.Inject(..., HTTPHeadersWriter&) (jaegertracing#107)
e0093b6 
tracer.Inject(SpanContext&, HTTPHeadersWriter&) was using the underlying
TextMapPropagator (instead of HTTPHeaderPropagator). This caused
injected baggage values not to be encoded.

Signed-off-by: Hugo Fernandes <hugof225@gmail.com>
isaachier pushed a commit that referenced this issue May 16, 2018
@HugoMFernandes @isaachier
Fix tracer.Inject(..., HTTPHeadersWriter&) (#107) (#108)
b749aed 
tracer.Inject(SpanContext&, HTTPHeadersWriter&) was using the underlying
TextMapPropagator (instead of HTTPHeaderPropagator). This caused
injected baggage values not to be encoded.

Signed-off-by: Hugo Fernandes <hugof225@gmail.com>
@isaachier
Copy link
Contributor

Fixed in #108.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@isaachier @HugoMFernandes