Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

jaeger cpp-client isn't in Hunter #51

Closed
ringerc opened this issue Jan 31, 2018 · 4 comments
Closed

jaeger cpp-client isn't in Hunter #51

ringerc opened this issue Jan 31, 2018 · 4 comments

Comments

@ringerc
Copy link
Contributor

ringerc commented Jan 31, 2018

Jaeger cpp-client appears to be intended to be used exclusively from/with Hunter, but it isn't in the Hunter repository/package list (https://docs.hunter.sh/en/latest/packages.html).

Mind posting an example of how you use it in your own codebase? Do you use Hunter to find dependencies then manually link to jaeger-cpp its self?

(I was adding a README explaining how to use jaeger-cpp with Hunter and couldn't figure out how!)

ringerc added a commit to ringerc/jaeger-cpp-client that referenced this issue Jan 31, 2018
ringerc added a commit to ringerc/jaeger-cpp-client that referenced this issue Jan 31, 2018
@ringerc
Copy link
Contributor Author

ringerc commented Jan 31, 2018

Presumably something like

# Do Hunter magic here, then
find_package(jaegertracing CONFIG REQUIRED)

It looks like the generated CMake config module that gets installed contains the required dependency find_package calls etc.

ringerc added a commit to ringerc/jaeger-cpp-client that referenced this issue Feb 1, 2018
ringerc added a commit to ringerc/jaeger-cpp-client that referenced this issue Feb 1, 2018
ringerc added a commit to ringerc/jaeger-cpp-client that referenced this issue Feb 1, 2018
ringerc added a commit to ringerc/jaeger-cpp-client that referenced this issue Feb 1, 2018
ringerc added a commit to ringerc/jaeger-cpp-client that referenced this issue Feb 1, 2018
ringerc added a commit to ringerc/jaeger-cpp-client that referenced this issue Feb 1, 2018
ringerc added a commit to ringerc/jaeger-cpp-client that referenced this issue Feb 1, 2018
ringerc added a commit to ringerc/jaeger-cpp-client that referenced this issue Feb 2, 2018
@isaachier
Copy link
Contributor

Lol I have thought about adding it but haven't yet. Thanks for posting.

@ringerc
Copy link
Contributor Author

ringerc commented Feb 7, 2018 via email

ringerc added a commit to ringerc/jaeger-cpp-client that referenced this issue Feb 13, 2018
@isaachier
Copy link
Contributor

Fixed in ruslo/hunter#1453. Will be available in Hunter release shortly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants