Skip to content
This repository has been archived by the owner on Apr 28, 2022. It is now read-only.

Added 128bit trace id configuration support #94

Merged
merged 2 commits into from
Jul 19, 2018

Conversation

Falco20019
Copy link
Collaborator

@Falco20019 Falco20019 commented Jul 18, 2018

Which problem is this PR solving?

Resolves #83

Short description of the changes

  • Added environment variable JAEGER_TRACEID_128BIT
  • Added WithTraceId128Bit method to Configuration
  • Added WithTraceId128Bit method to Tracer.Builder
  • Adde UseTraceId128Bit property to Tracer

Copy link
Collaborator

@grounded042 grounded042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@@ -82,6 +82,7 @@ JAEGER_SAMPLER_TYPE | no | The sampler type
JAEGER_SAMPLER_PARAM | no | The sampler parameter (number)
JAEGER_SAMPLER_MANAGER_HOST_PORT | no | The host name and port when using the remote controlled sampler
JAEGER_TAGS | no | A comma separated list of `name = value` tracer level tags, which get added to all reported spans. The value can also refer to an environment variable using the format `${envVarName:default}`, where the `:default` is optional, and identifies a value to be used if the environment variable cannot be found
JAEGER_TRACEID_128BIT | no | Whether to use 128bit TraceID instead of 64bit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay documentation!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add to the main docs - jaegertracing/documentation#105

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants