This repository has been archived by the owner on May 23, 2024. It is now read-only.
zipkin HTTP transport swallows HTTP error codes #330
Comments
mpuncel
added a commit
to mpuncel/jaeger-client-go
that referenced
this issue
Aug 30, 2018
…rtracing#330) Signed-off-by: Michael Puncel <mpuncel@squareup.com>
mpuncel
added a commit
to mpuncel/jaeger-client-go
that referenced
this issue
Aug 30, 2018
…rtracing#330) Signed-off-by: Michael Puncel <mpuncel@squareup.com>
mpuncel
added a commit
to mpuncel/jaeger-client-go
that referenced
this issue
Aug 30, 2018
…rtracing#330) Signed-off-by: Michael Puncel <mpuncel@squareup.com>
mpuncel
added a commit
to mpuncel/jaeger-client-go
that referenced
this issue
Aug 30, 2018
…rtracing#330) Signed-off-by: Michael Puncel <mpuncel@squareup.com>
mpuncel
added a commit
to mpuncel/jaeger-client-go
that referenced
this issue
Sep 6, 2018
…rtracing#330) Signed-off-by: Michael Puncel <mpuncel@squareup.com>
mpuncel
added a commit
to mpuncel/jaeger-client-go
that referenced
this issue
Sep 6, 2018
…rtracing#330) Signed-off-by: Michael Puncel <mpuncel@squareup.com>
mpuncel
added a commit
to mpuncel/jaeger-client-go
that referenced
this issue
Sep 6, 2018
…rtracing#330) Signed-off-by: Michael Puncel <mpuncel@squareup.com>
mpuncel
added a commit
to mpuncel/jaeger-client-go
that referenced
this issue
Sep 6, 2018
…rtracing#330) Signed-off-by: Michael Puncel <mpuncel@squareup.com>
yurishkuro
pushed a commit
that referenced
this issue
Oct 8, 2018
… (#331) Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Problem
The zipkin HTTP transport only returns an error from
send()if there is an error making the request, but not if the response has an HTTP error code.Proposal
Return an error if the HTTP response code is >= 400, which is what the jaeger HTTP transport does
The text was updated successfully, but these errors were encountered: