Import of "testing" package

[aaronbee]

Describe the bug
Importing jaeger-client-go adds a dependency on the standard library "testing" package. This is undesirable because production Go programs should not depend on the testing package. In addition to unnecessary bloat, "testing" adds a bunch of command line flags.

Here is the dependency graph that leads to "testing":

github.com/uber/jaeger-client-go -> 
github.com/uber/jaeger-client-go/utils ->
github.com/uber/jaeger-client-go/thrift-gen/jaeger ->
github.com/uber/jaeger-client-go/thrift -> 
testing

jaeger-client-go/thrift/logger.go is the file that imports "testing"

To Reproduce
go list -deps github.com/uber/jaeger-client-go | grep '^testing$'

Expected behavior
jaeger-client-go should not depend on "testing".

Version (please complete the following information):
Found in v2.29.0, not found in v2.28.0.

[yurishkuro]

Added a fix in #586.

The dependency comes from vendored Thrift, so I opened a ticket there too: https://issues.apache.org/jira/browse/THRIFT-5420

[yurishkuro]

https://github.com/jaegertracing/jaeger-client-go/releases/tag/v2.29.1

[yurishkuro]

@aaronbee could you elaborate on "adds a bunch of command line flags"? How does this manifest?

[aaronbee]

Thanks for the fix.

I was mistaken on the flags issue. In earlier versions of Go if you had an import of "testing" it would register a bunch of test-specific flags so that your program's help output would include things like:

  -test.bench regexp
    	run only benchmarks matching regexp
  -test.benchmem
    	print memory allocations for benchmarks
  -test.benchtime d
    	run each benchmark for duration d (default 1s)