Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Remove dependency on "testing" in "thrift" #586

Merged
merged 1 commit into from
May 24, 2021

Conversation

yurishkuro
Copy link
Member

Resolves #585

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner May 24, 2021 20:20
@yurishkuro yurishkuro requested review from objectiser and removed request for a team May 24, 2021 20:20
@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #586 (79f2470) into master (bf267c1) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #586      +/-   ##
==========================================
+ Coverage   88.58%   88.64%   +0.06%     
==========================================
  Files          61       61              
  Lines        3328     3328              
==========================================
+ Hits         2948     2950       +2     
+ Misses        252      251       -1     
+ Partials      128      127       -1     
Impacted Files Coverage Δ
utils/reconnecting_udp_conn.go 91.54% <0.00%> (+2.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf267c1...79f2470. Read the comment docs.

@yurishkuro yurishkuro merged commit ee200a7 into jaegertracing:master May 24, 2021
@yurishkuro yurishkuro deleted the fix-585 branch May 24, 2021 21:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import of "testing" package
1 participant