Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Add more stricter or granular lock for AdaptiveSampler.IsSampled() #69

Closed
black-adder opened this issue Dec 15, 2016 · 0 comments
Closed

Comments

@black-adder
Copy link
Contributor

https://github.com/uber/jaeger-client-go/blob/master/sampler.go#L310

AdaptiveSampler.IsSampled() is called by RemotelyControlledSampler.IsSampled(); however, the read lock doesn't prevent AdaptiveSampler from creating more samplers. Either change it to use a write lock or add more granular locking.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant