Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Document that JAEGER_SAMPLER_MANAGER_HOST_PORT should be URL #329

Merged
merged 1 commit into from
Sep 3, 2018
Merged

Document that JAEGER_SAMPLER_MANAGER_HOST_PORT should be URL #329

merged 1 commit into from
Sep 3, 2018

Conversation

gouthamve
Copy link
Contributor

Fixes #326

@gouthamve
Document that JAEGER_SAMPLER_MANAGER_HOST_PORT should be URL
e535c85 
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
@codecov
Copy link

codecov bot commented Aug 30, 2018 •
edited
Loading

Codecov Report

Merging #329 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #329   +/-   ##
=======================================
  Coverage   87.14%   87.14%           
=======================================
  Files          54       54           
  Lines        2988     2988           
=======================================
  Hits         2604     2604           
  Misses        272      272           
  Partials      112      112

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 252d853...e535c85. Read the comment docs.

yurishkuro
yurishkuro approved these changes Sep 3, 2018
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@yurishkuro yurishkuro merged commit 12b4b58 into jaegertracing:master Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gouthamve @yurishkuro