chore(docs): fixed a couple of typos #475
Conversation
Signed-off-by: Marc Bramaud <m.duboucheron@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #475 +/- ##
======================================
Coverage 88.1% 88.1%
======================================
Files 59 59
Lines 3507 3507
======================================
Hits 3090 3090
Misses 305 305
Partials 112 112Continue to review full report at Codecov.
|
thrift-gen/zipkincore/ttypes.go
Outdated
| @@ -741,7 +741,7 @@ func (p *BinaryAnnotation) String() string { | |||
| // precise measurement decoupled from problems of clocks, such as skew or NTP | |||
| // updates causing time to move backwards. | |||
| // | |||
| // For compatibilty with instrumentation that precede this field, collectors | |||
| // For compatibiltiy with instrumentation that precede this field, collectors | |||
There was a problem hiding this comment.
please do not make changes in the auto-generated files
There was a problem hiding this comment.
ah, my bad. Can you point me to the source so I can make the change there?
Signed-off-by: Marc Bramaud <m.duboucheron@gmail.com>
|
I reverted the changes to generated files and only kept the one to If you could point me to the source of the generated files so I can fix the typo there it would be amazing, I'll include that change in another PR. |
|
Thanks. The source is most likely in the jaeger-idl repo which is included here as a submodule. |
Signed-off-by: Marc Bramaud m.duboucheron@gmail.com
Which problem is this PR solving?
31 typos inREADME.mdandthrift-gen/zipkincore/ttypes.go