Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Move thrift compilation to a script #590

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Move thrift compilation to a script #590

merged 1 commit into from
Aug 5, 2021

Conversation

aaronjheng
Copy link
Contributor

Signed-off-by: Aaron Jheng wentworth@outlook.com

Which problem is this PR solving?

  • make thrift is not working on Linux.

Short description of the changes

  • Create a script for thrift compilation.

Signed-off-by: Aaron Jheng <wentworth@outlook.com>
@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #590 (d84bece) into master (b29e5f0) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #590      +/-   ##
==========================================
+ Coverage   88.58%   88.64%   +0.06%     
==========================================
  Files          61       61              
  Lines        3328     3328              
==========================================
+ Hits         2948     2950       +2     
+ Misses        252      251       -1     
+ Partials      128      127       -1     
Impacted Files Coverage Δ
utils/reconnecting_udp_conn.go 91.54% <0.00%> (+2.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29e5f0...d84bece. Read the comment docs.

@aaronjheng aaronjheng marked this pull request as ready for review August 5, 2021 02:16
@aaronjheng aaronjheng requested a review from a team as a code owner August 5, 2021 02:16
@aaronjheng aaronjheng requested review from yurishkuro and removed request for a team August 5, 2021 02:16
@yurishkuro
Copy link
Member

Local test:

$ \rm -rf thrift-gen/*
zsh: sure you want to delete all the files in /Users/ysh/golang/src/github.com/uber/jaeger-client-go/thrift-gen [yn]? y

$ git status
On branch thrift-gen
Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	deleted:    thrift-gen/agent/GoUnusedProtection__.go
	deleted:    thrift-gen/agent/agent-consts.go
	deleted:    thrift-gen/agent/agent.go
	deleted:    thrift-gen/baggage/GoUnusedProtection__.go
	deleted:    thrift-gen/baggage/baggage-consts.go
	deleted:    thrift-gen/baggage/baggage.go
	deleted:    thrift-gen/jaeger/GoUnusedProtection__.go
	deleted:    thrift-gen/jaeger/jaeger-consts.go
	deleted:    thrift-gen/jaeger/jaeger.go
	deleted:    thrift-gen/sampling/GoUnusedProtection__.go
	deleted:    thrift-gen/sampling/sampling-consts.go
	deleted:    thrift-gen/sampling/sampling.go
	deleted:    thrift-gen/zipkincore/GoUnusedProtection__.go
	deleted:    thrift-gen/zipkincore/zipkincore-consts.go
	deleted:    thrift-gen/zipkincore/zipkincore.go

no changes added to commit (use "git add" and/or "git commit -a")

$ make thrift-compile
docker run -v "/Users/ysh/golang/src/github.com/uber/jaeger-client-go:/data" -u 501:20 jaegertracing/thrift:0.14 thrift -version
Thrift version 0.14.1
docker run -v "/Users/ysh/golang/src/github.com/uber/jaeger-client-go:/data" -u 501:20 jaegertracing/thrift:0.14 /data/scripts/gen-thrift.sh
[WARNING:/data/idl/thrift/jaeger.thrift:19] No generator named 'netcore' could be found!
[WARNING:/data/idl/thrift/zipkincore.thrift:20] No generator named 'netcore' could be found!
[WARNING:/data/idl/thrift/agent.thrift:22] No generator named 'netcore' could be found!
[WARNING:/data/idl/thrift/sampling.thrift:19] No generator named 'netcore' could be found!
[WARNING:/data/idl/thrift/jaeger.thrift:19] No generator named 'netcore' could be found!
[WARNING:/data/idl/thrift/zipkincore.thrift:20] No generator named 'netcore' could be found!
[WARNING:/data/idl/thrift/baggage.thrift:19] No generator named 'netcore' could be found!
[WARNING:/data/idl/thrift/crossdock/tracetest.thrift:20] No generator named 'netcore' could be found!

$ git status
On branch thrift-gen
nothing to commit, working tree clean

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yurishkuro yurishkuro changed the title Tweak thrift compilation Move thrift compilation to a script Aug 5, 2021
@yurishkuro yurishkuro merged commit a600bc4 into jaegertracing:master Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants