Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Fix missing sampler tags in generated root span when startSpan #612

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChenX1993
Copy link

@ChenX1993 ChenX1993 commented Dec 20, 2022

Signed-off-by: Chen Xu chen.x@uber.com

Which problem is this PR solving?

Short description of the changes

  • Remove the code to create a new slice to sp.tags
  • Update and add unit tests to verify

Additional explanation

I understand the jaeger-client-go is deprecated, and no new PR request is accepted.
I just need to create a public PR (not need to merge), then I can patch in our own internal repo following our process.

@ChenX1993 ChenX1993 requested a review from a team as a code owner December 20, 2022 23:38
@ChenX1993 ChenX1993 requested review from pavolloffay and removed request for a team December 20, 2022 23:38
Signed-off-by: Chen Xu <chen.x@uber.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Sampler tags are missing in root span generated from startSpan
1 participant