This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
Remove shadow dependency from jaeger-b3 #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`jaeger-b3` depended on a shadow version of `jaeger-core` that packaged `okhttp` to prevent an incompatibility with `io.zipkin.brave:brave-http` The version of `brave-http` that we depend on currently doesn't have this incompatibility, so depending on the shadow is unnecessary. Fixes #279 Signed-off-by: Prithvi Raj <p.r@uber.com>
ghost
assigned 
yurishkuro
approved these changes
Dec 12, 2017
Codecov Report
@@ Coverage Diff @@
## master #309 +/- ##
============================================
+ Coverage 83.79% 83.84% +0.04%
- Complexity 563 564 +1
============================================
Files 91 91
Lines 2222 2222
Branches 257 257
============================================
+ Hits 1862 1863 +1
+ Misses 258 257 -1
Partials 102 102
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jaeger-b3depended on a shadow version ofjaeger-corethat packagedokhttpto prevent an incompatibility withio.zipkin.brave:brave-httpThe version of
brave-httpthat we depend on currently doesn't havethis incompatibility, so depending on the shadow is unnecessary.
Fixes #279
Signed-off-by: Prithvi Raj p.r@uber.com