Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

[jaeger-client-java/apache instrumentation] Completely remove apache instrumentation dependence on jaeger-context #320

Merged
merged 2 commits into from
Jan 23, 2018

Conversation

dray92
Copy link
Contributor

@dray92 dray92 commented Jan 20, 2018

opentracing-0.31 Tracer interface completely removes the requirement for this module to depend on TracingUtils

…instrumentation dependence on jaeger-context

Signed-off-by: Debosmit Ray <debo@uber.com>
@codecov
Copy link

codecov bot commented Jan 20, 2018

Codecov Report

Merging #320 into master will decrease coverage by 0.1%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #320      +/-   ##
============================================
- Coverage      83.9%   83.79%   -0.11%     
- Complexity      562      563       +1     
============================================
  Files            91       91              
  Lines          2218     2222       +4     
  Branches        256      257       +1     
============================================
+ Hits           1861     1862       +1     
- Misses          257      258       +1     
- Partials        100      102       +2
Impacted Files Coverage Δ Complexity Δ
...r/jaeger/httpclient/TracingRequestInterceptor.java 72.22% <60%> (-6.35%) 4 <0> (ø)
...ger/httpclient/SpanCreationRequestInterceptor.java 91.66% <75%> (+8.33%) 5 <1> (ø) ⬇️
...ain/java/com/uber/jaeger/senders/ThriftSender.java 73.46% <0%> (-4.09%) 10% <0%> (ø)
...jaeger/reporters/protocols/ThriftUdpTransport.java 81.35% <0%> (-3.39%) 14% <0%> (ø)
...java/com/uber/jaeger/reporters/RemoteReporter.java 87.14% <0%> (-2.86%) 9% <0%> (ø)
...ger-core/src/main/java/com/uber/jaeger/Tracer.java 86.46% <0%> (+0.43%) 19% <0%> (+1%) ⬆️
...er/httpclient/SpanInjectionRequestInterceptor.java 91.66% <0%> (+16.66%) 3% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa755d2...ece269a. Read the comment docs.

Signed-off-by: Debosmit Ray <debo@uber.com>
@yurishkuro yurishkuro merged commit 57668fd into jaegertracing:master Jan 23, 2018
@debosmit
Copy link

Related to #188

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants