Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Fix ClassCastException when a wrapped span impl is activated instead … #327

Merged
merged 1 commit into from
Jan 31, 2018

Conversation

objectiser
Copy link
Contributor

…of the Jaeger Span

Signed-off-by: Gary Brown gary@brownuk.com

@ghost ghost assigned objectiser Jan 30, 2018
@ghost ghost added the review label Jan 30, 2018
…of the Jaeger Span

Signed-off-by: Gary Brown <gary@brownuk.com>
@codecov
Copy link

codecov bot commented Jan 30, 2018

Codecov Report

Merging #327 into master will increase coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #327      +/-   ##
============================================
+ Coverage     83.91%   84.17%   +0.26%     
  Complexity      565      565              
============================================
  Files            91       91              
  Lines          2225     2225              
  Branches        258      258              
============================================
+ Hits           1867     1873       +6     
+ Misses          257      251       -6     
  Partials        101      101
Impacted Files Coverage Δ Complexity Δ
...ger-core/src/main/java/com/uber/jaeger/Tracer.java 86.89% <100%> (ø) 20 <0> (ø) ⬇️
...java/com/uber/jaeger/reporters/RemoteReporter.java 90% <0%> (+2.85%) 9% <0%> (ø) ⬇️
...jaeger/reporters/protocols/ThriftUdpTransport.java 84.74% <0%> (+3.38%) 14% <0%> (ø) ⬇️
...ain/java/com/uber/jaeger/senders/ThriftSender.java 77.55% <0%> (+4.08%) 10% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b1b547...1e86636. Read the comment docs.

@objectiser
Copy link
Contributor Author

@yurishkuro Assuming no issues with the PR, would it be possible to do a release after it is merged as it is causing problems with the API extensions/java-metrics?

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A breaking change, unfortunately

@yurishkuro yurishkuro merged commit fda7ade into jaegertracing:master Jan 31, 2018
@ghost ghost removed the review label Jan 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants