This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
Adding annotated filter priorities for Jersey filters #329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some open bugs in Jersey (#2912, #3467) cause the framework to not honor filter binding priorities. For our internal libraries, we have found that keeping the binding priorities in the [5001, ∞) range while registering the filters keeps the ordering intact.
This change attempts to ensure that span is created very early in the request life-cycle, while giving room for consumers to manually register filters to priorities greater than
javax.ws.rs.Priorities.USER
, and yet, come before the span injection stage.Similar idea follows for the server side instrumentation.
Signed-off-by: Debosmit Ray debo@uber.com