Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Report java version as process tag #548

Closed
wants to merge 1 commit into from
Closed

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Sep 10, 2018

In a large organization, there is numbers of services deployed base on different version jdk, Java version should be collected as built-in tag.
It's better jaeger spark job and ui can provide a list view for specified tag (here is java.version), something like:

Service Tag (java.version)
A 1.8.0_181
B 1.8.0_181
C 9
D 10.0.2

Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
@yurishkuro
Copy link
Member

I have to disagree, for two reasons:

  • it's going to add massive amount of redundant data in the tracing backend. Presumably, an organization can get a breakdown of app->Java version by other means.

  • if your organization still wants to go in this direction, you can easily add the tags to the tracer through other means, eg via env variables. But if we add it to the core lib, everyone will get this whether they want it or not.

@quaff
Copy link
Contributor Author

quaff commented Sep 11, 2018

It's OK, I thought it would be a general feature. The point is the second section, I reported jaegertracing/jaeger-ui#246

@jpkrohling
Copy link
Collaborator

I'm closing this, as I think @yurishkuro has a great point :)

In any case, thanks for the PR! Keep sending your ideas, perhaps opening an issue on the repository first to discuss whether it would be merged.

@jpkrohling jpkrohling closed this Sep 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants