This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
Production and test code cleanup #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several unused variables, resource leaks or other minor glitches in test classes are fixed. Signed-off-by: Markus Heimbach <markus@esukram.org>
The used depricated constructor just consumed the given parameter and did not use it at all. Thus is is safe to use the default constructor. Signed-off-by: Markus Heimbach <markus@esukram.org>
An unused import remained in the class. Just removed it. Signed-off-by: Markus Heimbach <markus@esukram.org>
|
One thing that made me wonder in particular: Like in here: |
Codecov Report
@@ Coverage Diff @@
## master #664 +/- ##
=========================================
Coverage 89.59% 89.59%
Complexity 567 567
=========================================
Files 69 69
Lines 2086 2086
Branches 266 266
=========================================
Hits 1869 1869
Misses 135 135
Partials 82 82
Continue to review full report at Codecov.
|
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
None
Short description of the changes
During the work of #653 I saw some code that was generating warnings in the IDE. This PR does solve these.
Please let me know, what you think.