i hate you

Signed-off-by: Won Jun Jang <wjang@uber.com>
jaegertracing · Jun 7, 2018 · 3e878f7 · 3e878f7
1 parent cfff09d
commit 3e878f7
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/test/udp_sender.js b/test/udp_sender.js
@@ -281,11 +281,7 @@ describe('udp sender', () => {
   });
 
   it('should gracefully handle errors emitted by socket.send', done => {
-    const tracer = new Tracer('test-service-name', new RemoteReporter(sender), new ConstSampler(true));
-    const doneWrapper = function() {
-      tracer.close();
-      done();
-    };
+    let tracer = new Tracer('test-service-name', new RemoteReporter(sender), new ConstSampler(true));
     sender._host = 'foo.bar.xyz';
     // In Node 0.10 and 0.12 the error is logged twice: (1) from inline callback, (2) from on('error') handler.
     let expectLogs = semver.satisfies(process.version, '0.10.x || 0.12.x');
@@ -296,7 +292,8 @@ describe('udp sender', () => {
       error: msg => {
         assert.isOk(expectLogs);
         expect(msg).to.have.string('error sending spans over UDP: Error: getaddrinfo ENOTFOUND');
-        doneWrapper();
+        tracer.close();
+        done();
       },
     };
     tracer.startSpan('testSpan').finish();
@@ -305,7 +302,7 @@ describe('udp sender', () => {
       expect(err).to.have.string('error sending spans over UDP: Error: getaddrinfo ENOTFOUND');
       if (!expectLogs) {
         tracer.close();
-        doneWrapper();
+        done();
       }
     });
   });