This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
Migrate to Apache license v2 #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gary Brown <gary@brownuk.com>
yurishkuro
reviewed
Oct 9, 2017
|
|
||
| - Every file must have a licence block at the top. This is enforced using `uber-licence` |
There was a problem hiding this comment.
What is the replacement for uber-license? I don't see any changes to package.json, how did you perform replacement of the license headers? I think we need
- a validation step that fails the build if files don't have a license header
- optionally, an auto-formatter that adds the headers to new files
There was a problem hiding this comment.
Will investigate to see what options are available.
There was a problem hiding this comment.
how did you actually do the header replacement?
There was a problem hiding this comment.
perl :) - had a look at uber-license by it only uses MIT license. Will have a look for an automated checker/formatter tomorrow - hopefully we can find something suitable.
There was a problem hiding this comment.
perl
can you post it? Might come in handy in other repos.
There was a problem hiding this comment.
yurishkuro
approved these changes
Oct 9, 2017
Merged
Iuriy-Budnikov
pushed a commit
to agile-pm/jaeger-client-node
that referenced
this pull request
Sep 25, 2021
Closes jaegertracing#159 Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #158
Signed-off-by: Gary Brown gary@brownuk.com