Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

Require Node 6.x for building #235

Merged
merged 1 commit into from
Feb 26, 2018
Merged

Require Node 6.x for building #235

merged 1 commit into from
Feb 26, 2018

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Feb 26, 2018

  • only lint with Node 6.x as the primary dev version
  • reorder travis matrix to run critical tasks first

Signed-off-by: Yuri Shkuro ys@uber.com

@ghost ghost assigned yurishkuro Feb 26, 2018
@ghost ghost added the review label Feb 26, 2018
@yurishkuro yurishkuro changed the title Re-add husky as dev dependency and require Node 6.x for building Require Node 6.x for building Feb 26, 2018
Signed-off-by: Yuri Shkuro <ys@uber.com>
Copy link
Member

@tiffon tiffon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.787% when pulling 051ee21 on restore-husky into 6e7505c on master.

@yurishkuro yurishkuro merged commit 4d68f11 into master Feb 26, 2018
@ghost ghost removed the review label Feb 26, 2018
@yurishkuro yurishkuro deleted the restore-husky branch February 26, 2018 20:24
Iuriy-Budnikov pushed a commit to agile-pm/jaeger-client-node that referenced this pull request Sep 25, 2021
* fix: set attributes from SpanOptions

* fix: add more tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants