This repository has been archived by the owner on Jul 11, 2022. It is now read-only.
fix B3Codec extract error for b3 header #301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #301 +/- ##
=======================================
Coverage 95.91% 95.91%
=======================================
Files 25 25
Lines 1935 1935
Branches 265 265
=======================================
Hits 1856 1856
Misses 52 52
Partials 27 27
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Jan 18, 2021
| @@ -296,7 +296,7 @@ def inject(self, span_context, carrier): | |||
| carrier[self.sampled_header] = '1' | |||
|
|
|||
| def extract(self, carrier): | |||
| if not isinstance(carrier, dict): | |||
| if not hasattr(carrier, 'items'): | |||
There was a problem hiding this comment.
it doesn't seem like it'd work in py2. maybe six has an equivalent test function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes