Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish container - dockerx should not use tag BUILD_IMAGE #1270

Merged
merged 1 commit into from Oct 21, 2020
Merged

Publish container - dockerx should not use tag BUILD_IMAGE #1270

merged 1 commit into from Oct 21, 2020

Conversation

morlay
Copy link
Contributor

@morlay morlay commented Oct 21, 2020

fix #1267

@codecov
Copy link

codecov bot commented Oct 21, 2020 •
edited

Codecov Report

Merging #1270 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1270   +/-   ##
=======================================
  Coverage   87.38%   87.38%           
=======================================
  Files          90       90           
  Lines        4913     4913           
=======================================
  Hits         4293     4293           
  Misses        457      457           
  Partials      163      163

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d15e00...3c13a8f. Read the comment docs.

@morlay morlay changed the title build: make dockerx should not be with :latest to fix publish images workflow build: make dockerx should not be with tag BUILD_IMAGE Oct 21, 2020
@jpkrohling jpkrohling changed the title build: make dockerx should not be with tag BUILD_IMAGE Publish container - dockerx should not use tag BUILD_IMAGE Oct 21, 2020
@jpkrohling
Copy link
Contributor

Under which tag/name is it available with this change?

@morlay
Copy link
Contributor Author

morlay commented Oct 21, 2020 •
edited

Final image tags passed in .ci/publish-images.sh.

IMAGE_TAGS=${IMAGE_TAGS} make dockerx

May refactor in future when all in dockerx

@jpkrohling
Copy link
Contributor

IMAGE_TAGS=${IMAGE_TAGS} make dockerx

The IMAGE_TAGS has then to have a default value, like:

IMAGE_TAGS ?= "--tag $(BUILD_IMAGE)"

So that make dockerx won't require IMAGE_TAGS when executed locally.

@morlay
Copy link
Contributor Author

morlay commented Oct 21, 2020

Yes, i will upgrade this

@morlay
build: make dockerx tags should using IMAGE_TAGS
3c13a8f 
Signed-off-by: Morlay <morlay.null@gmail.com>
@mergify mergify bot merged commit 9091a47 into jaegertracing:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@morlay @jpkrohling