Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed constraint on namespace when obtaining available Jaeger instances #213

Conversation

jpkrohling
Copy link
Contributor

Fixes #60 by removing the namespace constraint when querying for available Jaegers, as Kubernetes will do the right thing and deliver only the ones that the Operator's account can see.

@gregoryfranklin: do you think you'd be able to try this one out?

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

…nces

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling
Copy link
Contributor Author

This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #213 into master will decrease coverage by 1.52%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
- Coverage    96.7%   95.18%   -1.53%     
==========================================
  Files          32       35       +3     
  Lines        1639     1848     +209     
==========================================
+ Hits         1585     1759     +174     
- Misses         41       75      +34     
- Partials       13       14       +1
Impacted Files Coverage Δ
pkg/inject/sidecar.go 100% <100%> (ø) ⬆️
pkg/strategy/production.go 90.32% <0%> (-9.68%) ⬇️
pkg/strategy/controller.go 100% <0%> (ø) ⬆️
pkg/deployment/collector.go 100% <0%> (ø) ⬆️
pkg/deployment/ingester.go 100% <0%> (ø) ⬆️
pkg/apis/io/v1alpha1/jaeger_types.go 100% <0%> (ø) ⬆️
pkg/deployment/query.go 100% <0%> (ø) ⬆️
pkg/deployment/all-in-one.go 100% <0%> (ø) ⬆️
pkg/account/main.go 100% <0%> (ø) ⬆️
pkg/storage/elasticsearch_role.go 100% <0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 991bd48...892c80b. Read the comment docs.

@jpkrohling
Copy link
Contributor Author

@pavolloffay could you please review this one?

Copy link
Member

@pavolloffay pavolloffay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs could point into the example

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling
Copy link
Contributor Author

Done, thanks!

@jpkrohling jpkrohling merged commit 2e005fc into jaegertracing:master Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants