Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PriorityClass for AllInOne strategy #2218

Merged
merged 6 commits into from
May 19, 2023
Merged

Add PriorityClass for AllInOne strategy #2218

merged 6 commits into from
May 19, 2023

Conversation

sonofgibs
Copy link
Contributor

@sonofgibs sonofgibs commented May 18, 2023

Which problem is this PR solving?

Short description of the changes

  • Add PriorityClass capability for allinone strategy; includes unit test & example
  • Please note that the make generate api path was changed to './apis/v1' in order to run the command.

Zinnia Gibson added 6 commits May 18, 2023 11:25
Signed-off-by: Zinnia Gibson <zgibson@d2iq.com>
Signed-off-by: Zinnia Gibson <zgibson@d2iq.com>
Signed-off-by: Zinnia Gibson <zgibson@d2iq.com>
Signed-off-by: Zinnia Gibson <zgibson@d2iq.com>
Signed-off-by: Zinnia Gibson <zgibson@d2iq.com>
Signed-off-by: Zinnia Gibson <zgibson@d2iq.com>
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4988678) 87.50% compared to head (ce69e4e) 87.51%.

❗ Current head ce69e4e differs from pull request most recent head be6c01f. Consider uploading reports for the commit be6c01f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2218   +/-   ##
=======================================
  Coverage   87.50%   87.51%           
=======================================
  Files         100      100           
  Lines        6908     6912    +4     
=======================================
+ Hits         6045     6049    +4     
  Misses        658      658           
  Partials      205      205           
Impacted Files Coverage Δ
apis/v1/jaeger_types.go 87.50% <ø> (ø)
pkg/deployment/all_in_one.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sonofgibs !

@frzifus frzifus enabled auto-merge (squash) May 19, 2023 10:12
@sonofgibs
Copy link
Contributor Author

@frzifus Would you be able to trigger a rerun of the miscellaneous-e2e test? The error seems that it's irrelevant to the PR-- thanks!

@frzifus frzifus merged commit 76b16a3 into jaegertracing:main May 19, 2023
23 checks passed
iblancasa pushed a commit to iblancasa/jaeger-operator that referenced this pull request May 26, 2023
* add priorityclass for allinone

Signed-off-by: Zinnia Gibson <zgibson@d2iq.com>

* add example

Signed-off-by: Zinnia Gibson <zgibson@d2iq.com>

* update all in one deployment

Signed-off-by: Zinnia Gibson <zgibson@d2iq.com>

* added deployment test

Signed-off-by: Zinnia Gibson <zgibson@d2iq.com>

* add test

Signed-off-by: Zinnia Gibson <zgibson@d2iq.com>

* updates after running generate

Signed-off-by: Zinnia Gibson <zgibson@d2iq.com>

---------

Signed-off-by: Zinnia Gibson <zgibson@d2iq.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AllInOne doesn't support priorityClass
2 participants