Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove jaeger agent #2497

Merged
merged 8 commits into from
Jun 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ jobs:
- { name: "examples", label: "Examples" }
- { name: "generate", label: "Generate" }
- { name: "miscellaneous", label: "Miscellaneous" }
- { name: "sidecar", label: "Sidecar" }
- { name: "streaming", label: "Streaming" }
- { name: "ui", label: "UI" }
- { name: "upgrade", label: "Upgrade" }
Expand Down
2 changes: 1 addition & 1 deletion apis/v1/jaeger_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ type JaegerIngesterSpec struct {
NodeSelector map[string]string `json:"nodeSelector,omitempty"`
}

// JaegerAgentSpec defines the options to be used when deploying the agent
// JaegerAgentSpec is deprecated and disabled.
type JaegerAgentSpec struct {
// Strategy can be either 'DaemonSet' or 'Sidecar' (default)
// +optional
Expand Down
5 changes: 4 additions & 1 deletion apis/v1/jaeger_webhook.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
// Default implements webhook.Defaulter so a webhook will be registered for the type
func (j *Jaeger) Default() {
jaegerlog.Info("default", "name", j.Name)
jaegerlog.Info("WARNING jaeger-agent is deprecated and will removed in v1.55.0. See https://github.com/jaegertracing/jaeger/issues/4739", "component", "agent")

if j.Spec.Storage.Elasticsearch.Name == "" {
j.Spec.Storage.Elasticsearch.Name = defaultElasticsearchName
Expand Down Expand Up @@ -97,6 +96,10 @@
func (j *Jaeger) ValidateUpdate(_ runtime.Object) (admission.Warnings, error) {
jaegerlog.Info("validate update", "name", j.Name)

if len(j.Spec.Agent.Options.opts) != 0 {
return nil, fmt.Errorf("Jaeger agent configuration is no longer supported. See https://github.com/jaegertracing/jaeger/issues/4739. Values: %+v", j.Spec.Agent.Options.opts)

Check warning on line 100 in apis/v1/jaeger_webhook.go

View check run for this annotation

Codecov / codecov/patch

apis/v1/jaeger_webhook.go#L100

Added line #L100 was not covered by tests
}

if ShouldInjectOpenShiftElasticsearchConfiguration(j.Spec.Storage) && j.Spec.Storage.Elasticsearch.DoNotProvision {
// check if ES instance exists
es := &esv1.Elasticsearch{}
Expand Down
66 changes: 0 additions & 66 deletions bundle/manifests/jaeger-operator.clusterserviceversion.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -134,26 +134,6 @@ spec:
- patch
- update
- watch
- apiGroups:
- apps
resources:
- deployments
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- apps
resources:
- deployments/status
verbs:
- get
- patch
- update
- apiGroups:
- autoscaling
resources:
Expand Down Expand Up @@ -218,26 +198,6 @@ spec:
- patch
- update
- watch
- apiGroups:
- ""
resources:
- namespaces
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- ""
resources:
- namespaces/status
verbs:
- get
- patch
- update
- apiGroups:
- extensions
resources:
Expand Down Expand Up @@ -533,32 +493,6 @@ spec:
name: jaeger-operator
version: 1.57.0
webhookdefinitions:
- admissionReviewVersions:
- v1
containerPort: 443
deploymentName: jaeger-operator
failurePolicy: Ignore
generateName: deployment.sidecar-injector.jaegertracing.io
objectSelector:
matchExpressions:
- key: name
operator: NotIn
values:
- jaeger-operator
rules:
- apiGroups:
- apps
apiVersions:
- v1
operations:
- CREATE
- UPDATE
resources:
- deployments
sideEffects: None
targetPort: 9443
type: MutatingAdmissionWebhook
webhookPath: /mutate-v1-deployment
- admissionReviewVersions:
- v1
containerPort: 443
Expand Down
40 changes: 0 additions & 40 deletions config/rbac/role.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,26 +19,6 @@ rules:
- patch
- update
- watch
- apiGroups:
- apps
resources:
- deployments
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- apps
resources:
- deployments/status
verbs:
- get
- patch
- update
- apiGroups:
- autoscaling
resources:
Expand Down Expand Up @@ -103,26 +83,6 @@ rules:
- patch
- update
- watch
- apiGroups:
- ""
resources:
- namespaces
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- ""
resources:
- namespaces/status
verbs:
- get
- patch
- update
- apiGroups:
- extensions
resources:
Expand Down
12 changes: 0 additions & 12 deletions config/webhook/deployment_inject_patch.yaml

This file was deleted.

2 changes: 1 addition & 1 deletion config/webhook/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ configurations:
- kustomizeconfig.yaml

patchesStrategicMerge:
- deployment_inject_patch.yaml
- remove_deployment_webhook_patch.yaml
20 changes: 0 additions & 20 deletions config/webhook/manifests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,26 +24,6 @@ webhooks:
resources:
- jaegers
sideEffects: None
- admissionReviewVersions:
- v1
clientConfig:
service:
name: webhook-service
namespace: system
path: /mutate-v1-deployment
failurePolicy: Ignore
name: deployment.sidecar-injector.jaegertracing.io
rules:
- apiGroups:
- apps
apiVersions:
- v1
operations:
- CREATE
- UPDATE
resources:
- deployments
sideEffects: None
---
apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
Expand Down
8 changes: 8 additions & 0 deletions config/webhook/remove_deployment_webhook_patch.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
apiVersion: admissionregistration.k8s.io/v1
kind: MutatingWebhookConfiguration
metadata:
name: mutating-webhook-configuration
webhooks:
- name: deployment.sidecar-injector.jaegertracing.io
$patch: delete
Loading
Loading