Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the CI #2505

Merged
merged 3 commits into from
Mar 16, 2024
Merged

Fix the CI #2505

merged 3 commits into from
Mar 16, 2024

Conversation

iblancasa
Copy link
Collaborator

Closes #2503

…o test

Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@iblancasa iblancasa self-assigned this Mar 14, 2024
@IshwarKanse
Copy link
Contributor

/retest

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 87.69%. Comparing base (2583d2a) to head (2450991).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/autodetect/main.go 88.23% 1 Missing and 1 partial ⚠️
pkg/ingress/query.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2505      +/-   ##
==========================================
- Coverage   87.69%   87.69%   -0.01%     
==========================================
  Files         102      102              
  Lines        7274     7298      +24     
==========================================
+ Hits         6379     6400      +21     
- Misses        699      701       +2     
- Partials      196      197       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@rubenvp8510 rubenvp8510 merged commit 6d35c98 into jaegertracing:main Mar 16, 2024
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: broken CI TestForDefaultIngressClass
3 participants