Add sidecar.istio.io/inject=false annotation to all-in-one, agent (da… #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emonset), query and collector Signed-off-by: Gary Brown <gary@brownuk.com>
|
This change is |
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
=========================================
+ Coverage 99.29% 99.3% +<.01%
=========================================
Files 17 17
Lines 714 718 +4
=========================================
+ Hits 709 713 +4
Misses 5 5
Continue to review full report at Codecov.
|
jpkrohling
approved these changes
Oct 16, 2018
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
andream16
pushed a commit
to andream16/jaeger-operator
that referenced
this pull request
Oct 17, 2018
jaegertracing#67) * Add sidecar.istio.io/inject=false annotation to all-in-one, agent (daemonset), query and collector Signed-off-by: Gary Brown <gary@brownuk.com>
|
istioctl analyse complains about these injector annotation on a deployment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…emonset), query and collector
As annotations are ignored if not relevant, just added to the list. However in future, if necessary we could detect whether jaeger is being deployed into an Istio enabled cluster, and possibly only add the annotation then.
Signed-off-by: Gary Brown gary@brownuk.com