Adding test for SpanDetailRow

Signed-off-by: David-Emmanuel Divernois <david-emmanuel.divernois@amadeus.com>
jaegertracing · Jul 6, 2018 · 136c149 · 136c149
1 parent 858bb10
commit 136c149
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetailRow.js b/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetailRow.js
@@ -58,7 +58,6 @@ export default class SpanDetailRow extends React.PureComponent<SpanDetailRowProp
       columnDivision,
       detailState,
       isFilteredOut,
-      linksGetter,
       logItemToggle,
       logsToggle,
       processToggle,
@@ -84,7 +83,7 @@ export default class SpanDetailRow extends React.PureComponent<SpanDetailRowProp
           <div className="detail-info-wrapper" style={{ borderTopColor: color }}>
             <SpanDetail
               detailState={detailState}
-              linksGetter={linksGetter ? this._linksGetter : null}
+              linksGetter={this._linksGetter}
               logItemToggle={logItemToggle}
               logsToggle={logsToggle}
               processToggle={processToggle}

diff --git a/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetailRow.test.js b/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetailRow.test.js
@@ -27,11 +27,13 @@ describe('<SpanDetailRow>', () => {
     columnDivision: 0.5,
     detailState: new DetailState(),
     onDetailToggled: jest.fn(),
+    linksGetter: jest.fn(),
     isFilteredOut: false,
     logItemToggle: jest.fn(),
     logsToggle: jest.fn(),
     processToggle: jest.fn(),
     span: { spanID, depth: 3 },
+    spanIndex: 4,
     tagsToggle: jest.fn(),
     traceStartTime: 1000,
   };
@@ -40,6 +42,7 @@ describe('<SpanDetailRow>', () => {
 
   beforeEach(() => {
     props.onDetailToggled.mockReset();
+    props.linksGetter.mockReset();
     props.logItemToggle.mockReset();
     props.logsToggle.mockReset();
     props.processToggle.mockReset();
@@ -72,7 +75,7 @@ describe('<SpanDetailRow>', () => {
     const spanDetail = (
       <SpanDetail
         detailState={props.detailState}
-        linksGetter={null}
+        linksGetter={wrapper.instance()._linksGetter}
         logItemToggle={props.logItemToggle}
         logsToggle={props.logsToggle}
         processToggle={props.processToggle}
@@ -83,4 +86,16 @@ describe('<SpanDetailRow>', () => {
     );
     expect(wrapper.contains(spanDetail)).toBe(true);
   });
+
+  it('adds spanIndex when calling linksGetter', () => {
+    const spanDetail = wrapper.find(SpanDetail);
+    const linksGetter = spanDetail.prop('linksGetter');
+    const tags = [{ key: 'myKey', value: 'myValue' }];
+    const linksGetterResponse = {};
+    props.linksGetter.mockReturnValueOnce(linksGetterResponse);
+    const result = linksGetter(tags, 0);
+    expect(result).toBe(linksGetterResponse);
+    expect(props.linksGetter).toHaveBeenCalledTimes(1);
+    expect(props.linksGetter).toHaveBeenCalledWith(props.spanIndex, tags, 0);
+  });
 });