-
Notifications
You must be signed in to change notification settings - Fork 472
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[tests] Remove enzyme from QualityMetrics tests (#1684)
## Which problem is this PR solving? - part of #1668 - migrating the existing Enzyme based tests to React Testing Libary ## Description of the changes Currently I migrated 3 files - `QualityMetrics/BannerText.test.js` - `QualityMetrics/CountCard.test.js` ## How was this change tested? - replaced the shallow module from enzyme to render from RTL ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Freedisch <freeproduc@gmail.com> Signed-off-by: Freedisch <freeproduc@gamil.com> Co-authored-by: Freedisch <freeproduc@gamil.com>
- Loading branch information
Showing
4 changed files
with
36 additions
and
92 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 0 additions & 23 deletions
23
packages/jaeger-ui/src/components/QualityMetrics/__snapshots__/BannerText.test.js.snap
This file was deleted.
Oops, something went wrong.
46 changes: 0 additions & 46 deletions
46
packages/jaeger-ui/src/components/QualityMetrics/__snapshots__/CountCard.test.js.snap
This file was deleted.
Oops, something went wrong.