Deduplicate tags for spans

Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
jaegertracing · May 3, 2019 · ce20fcb · ce20fcb
1 parent fe6c244
commit ce20fcb
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/packages/jaeger-ui/src/model/transform-trace-data.tsx b/packages/jaeger-ui/src/model/transform-trace-data.tsx
@@ -15,10 +15,32 @@
 import _isEqual from 'lodash/isEqual';
 
 import { getTraceSpanIdsAsTree } from '../selectors/trace';
-import { Process, Span, SpanData, Trace, TraceData } from '../types/trace';
+import { KeyValuePair, Process, Span, SpanData, Trace, TraceData } from '../types/trace';
 import TreeNode from '../utils/TreeNode';
 
 type SpanWithProcess = SpanData & { process: Process };
+/*
+{
+  key: string;
+  value: any;
+};
+ */
+function deduplicateTags(span: Span) {
+  let hasDuplicated: boolean = false;
+  span.tags = span.tags.reduce<Array<KeyValuePair>>((uniqueTags, tag) => {
+    if (
+      !uniqueTags.some(t => {
+        return t.key === tag.key && t.value == tag.value;
+      })
+    ) {
+      uniqueTags.push(tag);
+    } else {
+      hasDuplicated = true;
+    }
+    return uniqueTags;
+  }, []);
+  span.hasDuplicatedTags = hasDuplicated;
+}
 
 /**
  * NOTE: Mutates `data` - Transform the HTTP response data into the form the app
@@ -93,6 +115,7 @@ export default function transformTraceData(data: TraceData & { spans: SpanWithPr
     span.relativeStartTime = span.startTime - traceStartTime;
     span.depth = depth - 1;
     span.hasChildren = node.children.length > 0;
+    deduplicateTags(span);
     span.references.forEach(ref => {
       const refSpan = spanMap.get(ref.spanID) as Span;
       if (refSpan) {

diff --git a/packages/jaeger-ui/src/types/trace.tsx b/packages/jaeger-ui/src/types/trace.tsx
@@ -61,6 +61,7 @@ export type Span = SpanData & {
   hasChildren: boolean;
   process: Process;
   relativeStartTime: number;
+  hasDuplicatedTags: boolean;
 };
 
 export type TraceData = {