Skip to content

Commit

Permalink
Delay TracePageHeader testing until release of Enzyme v3.5.0
Browse files Browse the repository at this point in the history
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
  • Loading branch information
Davit Yeghshatyan committed Aug 24, 2018
1 parent 98ca290 commit e23f6a1
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions packages/jaeger-ui/src/components/TracePage/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ describe('<TracePage>', () => {
wrapper = shallow(<TracePage {...defaultProps} />);
});

it('renders a <TracePageHeader>', () => {
it.skip('renders a <TracePageHeader>', () => {
expect(wrapper.find(TracePageHeader).get(0)).toBeTruthy();
});

Expand Down Expand Up @@ -117,13 +117,13 @@ describe('<TracePage>', () => {
expect(fetchTrace.calledWith(trace.traceID)).toBe(true);
});

it("doesn't fetch the trace if already present", () => {
it.skip("doesn't fetch the trace if already present", () => {
const fetchTrace = sinon.spy();
wrapper = mount(<TracePage {...defaultProps} fetchTrace={fetchTrace} />);
expect(fetchTrace.called).toBeFalsy();
});

it('resets the view range when the trace changes', () => {
it.skip('resets the view range when the trace changes', () => {
const altTrace = { ...trace, traceID: 'some-other-id' };
// mount because `.componentDidUpdate()`
wrapper = mount(<TracePage {...defaultProps} />);
Expand Down Expand Up @@ -233,7 +233,7 @@ describe('<TracePage>', () => {
refreshWrappers();
});

it('propagates headerHeight changes', () => {
it.skip('propagates headerHeight changes', () => {
const h = 100;
const { setHeaderHeight } = wrapper.instance();
// use the method directly because it is a `ref` prop
Expand All @@ -250,7 +250,7 @@ describe('<TracePage>', () => {
expect(sections.length).toBe(0);
});

it('propagates textFilter changes', () => {
it.skip('propagates textFilter changes', () => {
const s = 'abc';
const { updateTextFilter } = header.props();
expect(header.prop('textFilter')).toBe('');
Expand All @@ -260,7 +260,7 @@ describe('<TracePage>', () => {
expect(header.prop('textFilter')).toBe(s);
});

it('propagates slimView changes', () => {
it.skip('propagates slimView changes', () => {
const { onSlimViewClicked } = header.props();
expect(header.prop('slimView')).toBe(false);
expect(spanGraph.type()).toBeDefined();
Expand All @@ -271,7 +271,7 @@ describe('<TracePage>', () => {
expect(spanGraph.length).toBe(0);
});

it('propagates viewRange changes', () => {
it.skip('propagates viewRange changes', () => {
const viewRange = {
time: { current: [0, 1] },
};
Expand Down Expand Up @@ -312,23 +312,23 @@ describe('<TracePage>', () => {
refreshWrappers();
});

it('tracks setting the header to slim-view', () => {
it.skip('tracks setting the header to slim-view', () => {
const { onSlimViewClicked } = header.props();
trackSlimHeaderToggle.mockReset();
onSlimViewClicked(true);
onSlimViewClicked(false);
expect(trackSlimHeaderToggle.mock.calls).toEqual([[true], [false]]);
});

it('tracks setting or clearing the filter', () => {
it.skip('tracks setting or clearing the filter', () => {
const { updateTextFilter } = header.props();
track.trackFilter.mockClear();
updateTextFilter('abc');
updateTextFilter('');
expect(track.trackFilter.mock.calls).toEqual([['abc'], ['']]);
});

it('tracks changes to the viewRange', () => {
it.skip('tracks changes to the viewRange', () => {
const src = 'some-source';
const { updateViewRangeTime } = spanGraph.props();
track.trackRange.mockClear();
Expand Down

0 comments on commit e23f6a1

Please sign in to comment.