Skip to content

Commit

Permalink
Use correct duration format for scatter plot (#266)
Browse files Browse the repository at this point in the history
* Use correct duration format for scatter plot

Signed-off-by: Joe Farro <joef@uber.com>

* Fix issue with unit test

Signed-off-by: Joe Farro <joef@uber.com>
  • Loading branch information
tiffon authored and yurishkuro committed Oct 12, 2018
1 parent 6bbe0ef commit feeaccd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/jaeger-ui/src/api/jaeger.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import fetchMock from 'isomorphic-fetch';
import traceGenerator from '../demo/trace-generators';
import JaegerAPI, { getMessageFromError } from './jaeger';

const generatedTraces = traceGenerator.traces({ traces: 5 });
const generatedTraces = traceGenerator.traces({ numberOfTraces: 5 });

it('fetchTrace() should fetch with the id', () => {
fetchMock.mockClear();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ function ScatterPlotImpl(props) {
height={200}
>
<XAxis title="Time" tickTotal={4} tickFormat={t => moment(t).format('hh:mm:ss a')} />
<YAxis title="Duration" tickTotal={3} tickFormat={t => formatDuration(t, 'milliseconds')} />
<YAxis title="Duration" tickTotal={3} tickFormat={t => formatDuration(t)} />
<MarkSeries
sizeRange={[3, 10]}
opacity={0.5}
Expand Down

0 comments on commit feeaccd

Please sign in to comment.