Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: yarn start no longer works #1052

Closed
yurishkuro opened this issue Nov 12, 2022 · 3 comments · Fixed by #1054
Closed

[Bug]: yarn start no longer works #1052

yurishkuro opened this issue Nov 12, 2022 · 3 comments · Fixed by #1054
Labels

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Nov 12, 2022

What happened?

When developing UI features I should be able to start a dev version of the UI with yarn start

Steps to reproduce

  1. rm -rf node_modules packages/jaeger-ui/node_modules packages/plexus/node_modules
  2. yarn install --frozen-lockfile
  3. yarn start

Expected behavior

dev build of the UI should start

Relevant log output

$ yarn start
yarn run v1.22.18
$ cd packages/jaeger-ui && yarn start
$ react-app-rewired start
(node:24462) [DEP0111] DeprecationWarning: Access to process.binding('http_parser') is deprecated.
(Use `node --trace-deprecation ...` to show where the warning was created)
proxy is not a function
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Additional context

The yarn start worked at ce10d33. However, it does't seem to work anymore since 7896ab5, which contains an upgrade of many dependencies (PR #1001).

@mmorel-35 do you have any ideas what might have broken in the upgrade?

@yurishkuro yurishkuro added the bug label Nov 12, 2022
@mmorel-35
Copy link
Contributor

Hi @yurishkuro,
Is it the only logs you have ?
What if you rollback react-app-rewired update ?
Otherwise, the whole upgrade will have to be completely rolled-back

@yurishkuro
Copy link
Member Author

Those are all the logs from start command. If there's a debug mode I can try that. Are you saying that start works for you?

Ideally I would prefer to fix the issue than rollback so many updates.

@yurishkuro
Copy link
Member Author

yurishkuro commented Nov 13, 2022

Found the issue: facebook/create-react-app#8550. Will put a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants