Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: upgrade graph layout library #1081

Open
yurishkuro opened this issue Nov 25, 2022 · 3 comments
Open

[Feature]: upgrade graph layout library #1081

yurishkuro opened this issue Nov 25, 2022 · 3 comments

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Nov 25, 2022

Jaeger depends on a number of deprecated graph layout libs, like dagre and viz.js. It also provides a confusing assortment of graph views (force directed, DAG, and the latest graphs via plexus).

To avoid getting blocked on very old dependencies, we need to move to something newer.

One option to investigate: https://github.com/erikbrinkman/d3-dag

yurishkuro added a commit that referenced this issue Nov 25, 2022
Resolves #1077.

The upgrade was introduced in #1001. Sadly, we have no unit tests in
`/plexus/` module, so the break was not caught.

In #1001 the dependency viz.js was upgraded to the next major version
(2.1.2), however it had breaking changes which were not accounted for.

Alternative paths tracked in #1081.
@chethan27
Copy link

@yurishkuro can u assign this to me ? I would like to work on this .

@wthrajat
Copy link

@yurishkuro I understand the need to streamline and update the graph visualization dependencies but I wanted to seek clarification on what exactly you mean by "confusing".
Are you referring to the presence of multiple visualization choices? Do you prefer a default layout for the graph view? Like if we shift to d3-dag then the default layout would be directed acyclic graph and that would mean to not have the support of, say, force-directed layout anymore (I have not much researched about d3-dag yet but I think we have d3-force for force-directed, for example)
Did I get this right?

@yurishkuro
Copy link
Member Author

what exactly you mean by "confusing".

There is no good explanation in the UI why there are two graphs for overall topology. Practically, this was done more for technical reasons, but that doesn't need to be exposed to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants