Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: copy log entry VALUE as is #1503

Closed
neopaf opened this issue Jun 16, 2023 · 2 comments · Fixed by #1505
Closed

[Feature]: copy log entry VALUE as is #1503

neopaf opened this issue Jun 16, 2023 · 2 comments · Fixed by #1505

Comments

@neopaf
Copy link

neopaf commented Jun 16, 2023

Requirement

As a Jaeger UI user I want to be able to copy information from a log entry, from one of keys. Just value, nothing else.

Problem

Currently we have Copy JSON button that copies one key from log entry like this:

{
  "key": "key1",
  "type": "string",
  "value": "{\n  \"eventItem\": [{\n    \"UsageEventItem\": {\n      \"itemTime\": \"2023-05-31T10:22:58Z\",\n      \"usage\": {\n        ..."

While we need the content of value only.
Value is long and to just select and copy -> inconvenient.

Proposal

Please add Copy value somewhere icon next to Copy JSON that would copy only value, in my case:

{
  "eventItem": [{
    "UsageEventItem": {
      "itemTime": "2023-05-31T10:22:58Z",
      "usage": {

Open questions

No response

@yurishkuro
Copy link
Member

Original Copy JSON was added in #292 / #312.

yurishkuro added a commit that referenced this issue Jun 17, 2023
## Which problem is this PR solving?
- Resolves #1503 

## Short description of the changes
- Adds a second Copy icon that copies value only
- Change Copy JSON icon to `snippets`, to be visually different
- Reduce fade-out time for tooltip

Original Copy JSON was added in #292 / #312.

---------

Signed-off-by: Yuri Shkuro <ysh@meta.com>
@neopaf
Copy link
Author

neopaf commented Jul 11, 2023

@yurishkuro Yuri, my deep respect for this.
Karma += 1E9!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants