Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: jaeger-ui fails to compile on s390x due to a dependency on lerna/nx #1996

Closed
andreasgerstmayr opened this issue Nov 22, 2023 · 3 comments · Fixed by #1997
Closed

[Bug]: jaeger-ui fails to compile on s390x due to a dependency on lerna/nx #1996

andreasgerstmayr opened this issue Nov 22, 2023 · 3 comments · Fixed by #1997
Labels

Comments

@andreasgerstmayr
Copy link
Contributor

What happened?

As a maintainer I want to compile jaeger-ui on s390x.

Steps to reproduce

  1. start a s390x machine
  2. yarn install --frozen-lockfile

Expected behavior

Build fails with Error: Unsupported architecture on Linux: s390x

Relevant log output

[root@s390x-kvm-014 jaeger-ui]# yarn install --frozen-lockfile
yarn install v1.22.21
[...]
[4/4] Building fresh packages...
$ lerna run --stream --sort prepublishOnly
lerna notice cli v7.4.2
lerna ERR! Error: Unsupported architecture on Linux: s390x
lerna ERR!     at Object.<anonymous> (/root/jaeger/jaeger-ui/node_modules/nx/src/native/index.js:235:15)
lerna ERR!     at Module._compile (node:internal/modules/cjs/loader:1254:14)
lerna ERR!     at Module._extensions..js (node:internal/modules/cjs/loader:1308:10)
lerna ERR!     at Module.load (node:internal/modules/cjs/loader:1117:32)
lerna ERR!     at Module._load (node:internal/modules/cjs/loader:958:12)
lerna ERR!     at Module.require (node:internal/modules/cjs/loader:1141:19)
lerna ERR!     at require (node:internal/modules/cjs/helpers:110:18)
lerna ERR!     at /root/jaeger/jaeger-ui/node_modules/nx/src/project-graph/utils/retrieve-workspace-files.js:20:45
lerna ERR!     at Generator.next (<anonymous>)
lerna ERR! lerna Unsupported architecture on Linux: s390x
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.


### Screenshot

_No response_

### Additional context

_No response_

### Jaeger backend version

_No response_

### SDK

_No response_

### Pipeline

_No response_

### Stogage backend

_No response_

### Operating system

Linux on s390x

### Deployment model

_No response_

### Deployment configs

_No response_
@andreasgerstmayr
Copy link
Contributor Author

The lerna dependency depends on nx, which doesn't support s390x:
https://github.com/nrwl/nx/blob/16.6.0/packages/nx/src/native/index.js#L161
https://github.com/nrwl/nx/blob/16.6.0/docs/shared/installation/troubleshoot-installation.md#supported-native-module-platforms

I think the easiest way is to drop the lerna dependency, as suggested in #341. I'll have a PR ready soon.

@yurishkuro
Copy link
Member

Getting rid of lerna would be great. Unless it's a completely trivial change, please post some plan / findings on #341 first.

@andreasgerstmayr
Copy link
Contributor Author

imho it's a trivial change, mainly replacing lerna run with yarn workspaces run in package.json. The rest are changes to the docs: #1997.

This also removes lots of dependencies from yarn.lock :)

yurishkuro pushed a commit that referenced this issue Nov 23, 2023
## Which problem is this PR solving?
lerna/nx does not support s390x, and therefore the jaeger-ui build fails
on this platform. This PR removes the lerna dependency from jaeger-ui.


https://github.com/nrwl/nx/blob/16.6.0/packages/nx/src/native/index.js#L161

https://github.com/nrwl/nx/blob/16.6.0/docs/shared/installation/troubleshoot-installation.md#supported-native-module-platforms

Resolves: #1996
Resolves: #341

## Description of the changes
Remove `lerna` and use `yarn workspaces` instead. 

## How was this change tested?
- local

## Checklist
- [X] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [X] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants