Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A way to copy json text of json-formatted tag values #204

Open
mabn opened this issue Apr 10, 2018 · 2 comments
Open

A way to copy json text of json-formatted tag values #204

mabn opened this issue Apr 10, 2018 · 2 comments

Comments

@mabn
Copy link

mabn commented Apr 10, 2018

The way json values are displayed is pretty cool and readable (yay), but sometimes I want to copy such value and use it somewhere else. E.g. in case of request payloads or message content to replay them in some other tool.

The formatting removes quotes from field names so I have to either add them manually or find the relevant value in trace json and "unescape" it.

It would be cool if there was some way to either disable the formatting temporarily for a given field or to somehow copy the raw value to the clipboard.

@yurishkuro
Copy link
Member

I've think a copy icon would be useful here

@tiffon
Copy link
Member

tiffon commented Jun 17, 2018

@mabn Thanks for creating this ticket!

SGTM. The call-to-action can appear on hover of the table row. IMO the text "Copy" is more clear than an icon.

@tiffon tiffon removed the outreachy label Sep 3, 2018
everett980 added a commit to everett980/jaeger-ui that referenced this issue Dec 13, 2018
Signed-off-by: Everett Ross <reverett@uber.com>
everett980 added a commit to everett980/jaeger-ui that referenced this issue Dec 13, 2018
Signed-off-by: Everett Ross <reverett@uber.com>
@everett980 everett980 self-assigned this Dec 13, 2018
tiffon pushed a commit that referenced this issue Jan 4, 2019
* Add a copy icon to entries in KeyValuesTable (#204)

Signed-off-by: Everett Ross <reverett@uber.com>

* Add a tooltip to copy icon in KeyValuesTable

Signed-off-by: Everett Ross <reverett@uber.com>

* Fix copied test name, add test for KeyValuesTable state change on tooltip hide

Signed-off-by: Everett Ross <reverett@uber.com>

* Add eslint rule to prevent unnecessary braces in jsx

Signed-off-by: Everett Ross <reverett@uber.com>

* Add classname to tr to remove element selector, fix yarn.lock

Signed-off-by: Everett Ross <reverett@uber.com>
everett980 added a commit to everett980/jaeger-ui that referenced this issue Jan 16, 2019
…gertracing#292)

* Add a copy icon to entries in KeyValuesTable (jaegertracing#204)

Signed-off-by: Everett Ross <reverett@uber.com>

* Add a tooltip to copy icon in KeyValuesTable

Signed-off-by: Everett Ross <reverett@uber.com>

* Fix copied test name, add test for KeyValuesTable state change on tooltip hide

Signed-off-by: Everett Ross <reverett@uber.com>

* Add eslint rule to prevent unnecessary braces in jsx

Signed-off-by: Everett Ross <reverett@uber.com>

* Add classname to tr to remove element selector, fix yarn.lock

Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this issue Jul 5, 2021
…gertracing#292)

* Add a copy icon to entries in KeyValuesTable (jaegertracing#204)

Signed-off-by: Everett Ross <reverett@uber.com>

* Add a tooltip to copy icon in KeyValuesTable

Signed-off-by: Everett Ross <reverett@uber.com>

* Fix copied test name, add test for KeyValuesTable state change on tooltip hide

Signed-off-by: Everett Ross <reverett@uber.com>

* Add eslint rule to prevent unnecessary braces in jsx

Signed-off-by: Everett Ross <reverett@uber.com>

* Add classname to tr to remove element selector, fix yarn.lock

Signed-off-by: Everett Ross <reverett@uber.com>

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this issue Jul 5, 2021
…gertracing#292)

* Add a copy icon to entries in KeyValuesTable (jaegertracing#204)

Signed-off-by: Everett Ross <reverett@uber.com>

* Add a tooltip to copy icon in KeyValuesTable

Signed-off-by: Everett Ross <reverett@uber.com>

* Fix copied test name, add test for KeyValuesTable state change on tooltip hide

Signed-off-by: Everett Ross <reverett@uber.com>

* Add eslint rule to prevent unnecessary braces in jsx

Signed-off-by: Everett Ross <reverett@uber.com>

* Add classname to tr to remove element selector, fix yarn.lock

Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants