Open additional menu links in the same tab #275
Labels
Comments
zablvit
added a commit
to zablvit/jaeger-ui
that referenced
this issue
Nov 17, 2018
…tracing#275) Signed-off-by: Vitaliy Zabolotskyy <zablvit@gmail.com>
zablvit
added a commit
to zablvit/jaeger-ui
that referenced
this issue
Nov 17, 2018
Signed-off-by: Vitaliy Zabolotskyy <zablvit@gmail.com>
tiffon
pushed a commit
that referenced
this issue
Jan 9, 2019
* Ability to open additional menu links in same tab (#275) Signed-off-by: Vitaliy Zabolotskyy <zablvit@gmail.com> * Add negative test case Signed-off-by: Vitaliy Zabolotskyy <zablvit@gmail.com> * Add helper function to create item links Signed-off-by: Vitaliy Zabolotskyy <zablvit@gmail.com> * Fix no-use-before-define lint error Signed-off-by: Vitaliy Zabolotskyy <zablvit@gmail.com> * Use anchorTarget in custom menu configuration Signed-off-by: Joe Farro <joef@uber.com> * Fix typo in test case Signed-off-by: Joe Farro <joef@uber.com>
everett980
pushed a commit
to everett980/jaeger-ui
that referenced
this issue
Jan 16, 2019
…cing#275) (jaegertracing#278) * Ability to open additional menu links in same tab (jaegertracing#275) Signed-off-by: Vitaliy Zabolotskyy <zablvit@gmail.com> * Add negative test case Signed-off-by: Vitaliy Zabolotskyy <zablvit@gmail.com> * Add helper function to create item links Signed-off-by: Vitaliy Zabolotskyy <zablvit@gmail.com> * Fix no-use-before-define lint error Signed-off-by: Vitaliy Zabolotskyy <zablvit@gmail.com> * Use anchorTarget in custom menu configuration Signed-off-by: Joe Farro <joef@uber.com> * Fix typo in test case Signed-off-by: Joe Farro <joef@uber.com> Signed-off-by: Everett Ross <reverett@uber.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this issue
Jul 5, 2021
…cing#275) (jaegertracing#278) * Ability to open additional menu links in same tab (jaegertracing#275) Signed-off-by: Vitaliy Zabolotskyy <zablvit@gmail.com> * Add negative test case Signed-off-by: Vitaliy Zabolotskyy <zablvit@gmail.com> * Add helper function to create item links Signed-off-by: Vitaliy Zabolotskyy <zablvit@gmail.com> * Fix no-use-before-define lint error Signed-off-by: Vitaliy Zabolotskyy <zablvit@gmail.com> * Use anchorTarget in custom menu configuration Signed-off-by: Joe Farro <joef@uber.com> * Fix typo in test case Signed-off-by: Joe Farro <joef@uber.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this issue
Jul 5, 2021
…cing#275) (jaegertracing#278) * Ability to open additional menu links in same tab (jaegertracing#275) Signed-off-by: Vitaliy Zabolotskyy <zablvit@gmail.com> * Add negative test case Signed-off-by: Vitaliy Zabolotskyy <zablvit@gmail.com> * Add helper function to create item links Signed-off-by: Vitaliy Zabolotskyy <zablvit@gmail.com> * Fix no-use-before-define lint error Signed-off-by: Vitaliy Zabolotskyy <zablvit@gmail.com> * Use anchorTarget in custom menu configuration Signed-off-by: Joe Farro <joef@uber.com> * Fix typo in test case Signed-off-by: Joe Farro <joef@uber.com> Signed-off-by: Everett Ross <reverett@uber.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Requirement - what kind of business use case are you trying to solve?
tl;dr
Possibility to open additional menu links in global nav in the same tab (
target="_self")Detailed use case
I'm using keycloak gatekeeper to add login page to jaeger query and I want to add "Logout" link in top nav which will point to
/oauth/logoutwhich will end keycloack session and redirect to login page.In current state this will open new tab, perform logout and redirect to login screen, however this all happens in a new tab and jaeger ui tab is still open. I need this all to happen in the same tab.
Problem - what in Jaeger blocks you from solving the requirement?
Hardcoded
target="_blank"in hereProposal - what do you suggest to solve the problem or improve the existing situation?
Add
openInSameTabboolean field to ConfigMenuItem type which, if set to true will set link target to _selfThe text was updated successfully, but these errors were encountered: