Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query param to timeline view for deep linking #303

Closed
everett980 opened this issue Jan 3, 2019 · 1 comment
Closed

Add query param to timeline view for deep linking #303

everett980 opened this issue Jan 3, 2019 · 1 comment
Assignees

Comments

@everett980
Copy link
Collaborator

Requirement - what kind of business use case are you trying to solve?

Ability to link to a trace with a specified spanId selected and scrolled into view.

Problem - what in Jaeger blocks you from solving the requirement?

Currently there is no ability to link to a specific span.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Add an optional query param for spanId to specify which span should be selected and in view.

Any open questions to address

What to do if spanId is absent?
a) Ignore query param and behave as though not present.
b) (a) + small indicator that span id was not found

@everett980 everett980 self-assigned this Jan 3, 2019
@yurishkuro
Copy link
Member

I would add a dismissible warning banner at the top indicating that span id is not found in the trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants