Move filter to query param and highlight filter matches on graphs #310

everett980 · 2019-01-09T16:35:56Z

Which problem is this PR solving?

Resolves Add ability to search for nodes in TraceDiffGraph and TraceGraph #307
Resolves Add query param to timeline view for deep linking #303
Resolves Fix TracePageHeader tests once new version of Enzyme is released #239
Resolves Improve TraceDiff Test Coverage #318

Short description of the changes

Moving span filtering from state.filterText to a query param (uiFind) allows filters to be shared
On initial load of TimelineView with a truthy uiFind, all rows are collapsed except paths to matches and matches have details expanded
Graph nodes are outlined if they match filter
Filtering logic returns spans if their spanID === any filter word
SpanID in SpanRowDetail is clickable to add to filter to easily link to specific spans
Update Ezyme version, re-enable skipped tests, add tests to hit 100% coverage for TracePage/index.js and TraceDiff/

Demo

On initial load with three spanIDs provided:

Add another filter word

After clicking expand all

Changing filter does not hide / show any children nor expand detail states, only changes which rows are highlighted. On refresh all highlighted rows would have their detail states visible and spans not on any path to a highlighted row would be hidden.

Clickable SpanIDs

Find in Diff Graph

Diff Graph does not have header, uiFind is present in the bottom right

Finding Gif (old uiFind)

Updated uiFind

Updated uiFind Close Up

Find in Trace Graph

Close Up of Find

re-uses find header on Timeline view, but up and down arrows are disabled.

codecov · 2019-01-09T16:46:16Z

Codecov Report

Merging #310 into master will increase coverage by 7.53%.
The diff coverage is 89.34%.

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage   83.18%   90.72%   +7.53%     
==========================================
  Files         145      152       +7     
  Lines        3224     3288      +64     
  Branches      660      666       +6     
==========================================
+ Hits         2682     2983     +301     
+ Misses        434      250     -184     
+ Partials      108       55      -53

Impacted Files	Coverage Δ
...nts/TracePage/TraceTimelineViewer/SpanDetailRow.js	`100% <ø> (ø)`	⬆️
...nents/TracePage/TracePageHeader/TracePageHeader.js	`100% <ø> (+6.66%)`	⬆️
...omponents/TraceDiff/TraceDiffHeader/CohortTable.js	`100% <ø> (+85%)`	⬆️
...aeger-ui/src/components/TracePage/ScrollManager.js	`91.48% <0%> (-7.37%)`	⬇️
packages/jaeger-ui/src/model/trace-dag/TraceDag.js	`78.72% <0%> (+20.02%)`	⬆️
...ts/TracePage/TraceTimelineViewer/SpanTreeOffset.js	`100% <100%> (ø)`	⬆️
...c/components/TracePage/TraceTimelineViewer/duck.js	`100% <100%> (ø)`	⬆️
packages/jaeger-ui/src/utils/update-ui-find.js	`100% <100%> (ø)`
...rc/components/TraceDiff/TraceDiffGraph/drawNode.js	`100% <100%> (+80%)`	⬆️
...ackages/jaeger-ui/src/components/TraceDiff/duck.js	`100% <100%> (+86.2%)`	⬆️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a8a45...d3965dc. Read the comment docs.

tiffon · 2019-01-14T19:31:35Z

Can you add a gif / screenshot of the trace diff search? Also, the gif doesn't show much of a highlight... is it too grainy to see the highlight? If so, can you provide a screenshot of the effect?

And, for the trace graph, is it not possible to use the search already on the page? Seems odd to have a second search input field.

tiffon

Looks great. A couple of comments. LMK if any of them look awry.

tiffon · 2019-01-14T19:59:57Z

packages/jaeger-ui/src/components/common/GraphSearch.js

+}
+
+export function mapStateToProps(state: ReduxState): { graphSearch?: string } {
+  const { graphSearch } = queryString.parse(state.router.location.search);


It'd be nice to converge the graph and trace timeline search.

Also, for the query parameters, we took the approach of prefacing UI state related query params with ui<page><variable>, e.g. uiTraceDetailFind or something along those lines.

@tiffon I have been working on converging the graph and timeline search.
Things have changed quite a bit while working on the TraceTimeline search, should I close this PR and open a new one once #303 is done?

Also, I changed the name of the queryParameter to be more general, I will make sure it also includes the fact that it is a UI state variable, however I am not sure how to define the <page> part as this will be used for Trace Timeline, Trace Graph, and Trace Diff Graph.

Opening a new PR might make sense. Or, we can try the "discard review" feature and see what happens.

Re the query param, maybe simple uiFind would work?

tiffon · 2019-01-14T20:02:21Z

packages/jaeger-ui/src/utils/filter-spans.js

+  textFilter
+    .split(' ')
+    .map(s => s.trim())
+    .filter(s => s)


This can be .filter(Boolean).

tiffon · 2019-01-14T20:04:39Z

packages/jaeger-ui/src/utils/filter-spans.js

+
+  // split textFilter by whitespace, remove empty strings, and extract includeFilters and excludeKeys
+  textFilter
+    .split(' ')


.split(/\s+/) should remove the need for the .trim() map.

updated filter-spans with these two changes

tiffon · 2019-01-14T20:11:42Z

packages/jaeger-ui/src/components/common/GraphSearch.js

+    if (graphSearchQueryParam) {
+      queryParams.graphSearch = graphSearchQueryParam;
+    }
+    this.props.history.replace(prefixUrl(`?${queryString.stringify(queryParams)}`));


I would think this might always replace the URL with /?...., i.e. with the URL at the root (with the prefix)?

I'm not entirely sure how prefixUrl works, but it seems to work as expected on the timeline view and the diff view

tiffon · 2019-01-14T20:13:46Z

packages/jaeger-ui/src/components/common/GraphSearch.js

@@ -0,0 +1,109 @@
+// @flow


Seems like it might be nice to standardize naming where "search" is the search form and jaeger-query related and "find" is local to the UI. What do you think of renaming this to GraphFind?

as discussed above, changed to uiFind

everett980 · 2019-01-16T21:34:34Z

I merged my branch for #303 into this branch. I am going to attempt to Dismiss review (took screenshots in case they are simply deleted) and then will update the PR description to demonstrate the changes in #303 and #307.

Updated branch accordingly, along with other significant changes relating to #303

Add alternative view in TracePage which allows to see count, avg. time, total time and self time for a given trace grouped by service and operation. Signed-off-by: Patrick Coray <patrick.coray@bluewin.ch> Signed-off-by: Everett Ross <reverett@uber.com>

* Misc tweaks for search and trace detail embed mode Mostly from prior comments. - Rename query parameter for embedding to start with "ui" and use the page as the first word, e.g. "uiSearchHideGraph" - Change query parameters for the minimap and trace details from hiding to showing, e.g. "hidemap" -> "uiTimelineShowMap" - Save the embed query params in Redux state instead of passing them around - Use a Link with an icon instead of text buttons for opening the standalone view of the page - Propagate whether the trace detail page is from the search page or not via the Location#state member on the React Router Location - When returning to the search page use the previous results instead of executing a new search. This is done by storing the query with the search results. - Adjusted aesthetic of "Back to Search" button on trace detail page - Sequester parsing and stripping query parameters for the embed mode to a util - In various places switch to using the component/*/url.js#getUrl functions instead of prefixUrl(...) Signed-off-by: Joe Farro <joef@uber.com> * Fix test break from merging master Signed-off-by: Joe Farro <joef@uber.com> * Keep redux search query synced with results - Keep redux search query synced with redux search result (and their processing). Also fixes jaegertracing#288. - Bolster unit tests Signed-off-by: Joe Farro <joef@uber.com> * Fix typo Signed-off-by: Joe Farro <joef@uber.com> * Make TracePageHeader collapsible when embedded - Reconfigured embed query parameters for timeline: - uiTimelineCollapseTitle=1 - TracePageHeader starts out collapsed - uiTimelineHideMinimap=1 - TracePageHeader does not show the minimap - uiTimelineHideSummary=1 - TracePageHeader does not show the trace summary - Consolidate TracePageHeader and TracePageHeaderEmbed - Style changes to TracePageHeader - Embedded TracePageHeader can now be expanded and collapsed - Misc cleanup in TracePageHeader - Better comparisons for search page query to prevent re-fetching when returning to the search page Signed-off-by: Joe Farro <joef@uber.com> * Fix typo disableComparisions Signed-off-by: Joe Farro <joef@uber.com> * Use public registry to newly installed packages Signed-off-by: Joe Farro <joef@uber.com> * Test improvements Signed-off-by: Joe Farro <joef@uber.com> Signed-off-by: Everett Ross <reverett@uber.com>

Signed-off-by: Joe Farro <joef@uber.com> Signed-off-by: Everett Ross <reverett@uber.com>

…racing#290) * Add button to reset viewing layer zoom (jaegertracing#215) Signed-off-by: Everett Ross <reverett@uber.com> * Adhere to className pattern, sort imports, remove event handling Signed-off-by: Everett Ross <reverett@uber.com> Signed-off-by: Everett Ross <reverett@uber.com>

…gertracing#292) * Add a copy icon to entries in KeyValuesTable (jaegertracing#204) Signed-off-by: Everett Ross <reverett@uber.com> * Add a tooltip to copy icon in KeyValuesTable Signed-off-by: Everett Ross <reverett@uber.com> * Fix copied test name, add test for KeyValuesTable state change on tooltip hide Signed-off-by: Everett Ross <reverett@uber.com> * Add eslint rule to prevent unnecessary braces in jsx Signed-off-by: Everett Ross <reverett@uber.com> * Add classname to tr to remove element selector, fix yarn.lock Signed-off-by: Everett Ross <reverett@uber.com> Signed-off-by: Everett Ross <reverett@uber.com>

…tracing#244) (jaegertracing#291) * Add validation for duration fields in SearchForm (jaegertracing#244) Signed-off-by: Everett Ross <reverett@uber.com> * Add tests for redux-form-field-adapter Signed-off-by: Everett Ross <reverett@uber.com> * Fix boolean prop type Signed-off-by: Everett Ross <reverett@uber.com> * Add boolean for input validation, change popover to show when inactive Signed-off-by: Everett Ross <reverett@uber.com> * Add tests for onChangeAdapter Signed-off-by: Everett Ross <reverett@uber.com> * Create separate ValidatedAdaptedInput for duration fields Signed-off-by: Everett Ross <reverett@uber.com> * Remove unnecessary curly braces Signed-off-by: Everett Ross <reverett@uber.com> Signed-off-by: Everett Ross <reverett@uber.com>

…racing#297) * Add indent guides to trace timeline view (jaegertracing#172) Signed-off-by: Everett Ross <reverett@uber.com> * Add tests for connect functions, add more flow types Signed-off-by: Everett Ross <reverett@uber.com> * Consolidate ducks, remove redudant PropTypes, add event type Signed-off-by: Everett Ross <reverett@uber.com> * Rename hoverSpanId to hoverIndentGuideId Signed-off-by: Everett Ross <reverett@uber.com> * Derive props from span, use dataset over getAttribute Signed-off-by: Everett Ross <reverett@uber.com> Signed-off-by: Everett Ross <reverett@uber.com>

…gertracing#307) Signed-off-by: Everett Ross <reverett@uber.com>

Signed-off-by: Everett Ross <reverett@uber.com>

* WIP upgrade to create-react-app v2.1.2 Requires changes from PR jaegertracing#346 which are published as react-app-rewired@2.0.2-next.0 timarney/react-app-rewired#346 Signed-off-by: Joe Farro <joef@uber.com> * Use node 8, less liberal browser support, fix test Signed-off-by: Joe Farro <joef@uber.com> * Use eslintrc, fix CI build, fix pre-commit hook Make sure the ./packages/jaeger-ui uses the ./.eslintrc. Make sure all tests are run in pre-commit hook. CRA is now failing builds in CI if there are any webpack build warnings: https://github.com/facebook/create-react-app/blob/73e3d0ebf1f2834e1c8c41d3a25ae5e0e99e6f14/packages/react-scripts/scripts/build.js#L171-L184 Signed-off-by: Joe Farro <joef@uber.com> * Skip react-vis.css format check, fail-fast in CI Signed-off-by: Joe Farro <joef@uber.com> * Don't collect coverage from dev proxy setup Signed-off-by: Joe Farro <joef@uber.com> * Upgrade react-app-rewired to 2.0.1 Avoid issue yarnpkg/yarn#6300 Signed-off-by: Joe Farro <joef@uber.com> * Cleanup npm packages in packages/jaeger-ui Signed-off-by: Joe Farro <joef@uber.com> Signed-off-by: Everett Ross <reverett@uber.com>

Signed-off-by: Everett Ross <reverett@uber.com>

…cing#275) (jaegertracing#278) * Ability to open additional menu links in same tab (jaegertracing#275) Signed-off-by: Vitaliy Zabolotskyy <zablvit@gmail.com> * Add negative test case Signed-off-by: Vitaliy Zabolotskyy <zablvit@gmail.com> * Add helper function to create item links Signed-off-by: Vitaliy Zabolotskyy <zablvit@gmail.com> * Fix no-use-before-define lint error Signed-off-by: Vitaliy Zabolotskyy <zablvit@gmail.com> * Use anchorTarget in custom menu configuration Signed-off-by: Joe Farro <joef@uber.com> * Fix typo in test case Signed-off-by: Joe Farro <joef@uber.com> Signed-off-by: Everett Ross <reverett@uber.com>

* Revive the changelog Signed-off-by: Joe Farro <joef@uber.com> * Add helper script to generate CHANGELOG entries Signed-off-by: Joe Farro <joef@uber.com> * One more changelog item, fix date typo Signed-off-by: Joe Farro <joef@uber.com> * Fix phrasing in changelog Signed-off-by: Joe Farro <joef@uber.com> Signed-off-by: Everett Ross <reverett@uber.com>

Signed-off-by: Everett Ross <reverett@uber.com>

everett980 · 2019-03-05T21:03:45Z

Is there a reason to use the blur on the box-shadow? Seems like it might be a perf hit.

From what I can tell, only the yellow box-shadow is being used, not the grey outline. Seems like the outline might have better performance because it's a much simpler effect. Maybe we should use outline exclusively?

Seems as though mixing inheritance and definition when using both long-hand and short-hand css rules for outlines works a bit differently than I originally thought. I changed the isUiFindMatch styling to only add an outline, no box-shadow. Performance gains are always nice to have, and this has the benefit of no longer relying on the implicit color behavior of box-shadows without a color.

Signed-off-by: Everett Ross <reverett@uber.com>

Feedback has been addressed, will make issues for the outstanding work outside of the scope of this PR

…d-tracediffgraph

…aph' into issue-239-fix-TracePageHeader-tests-once-new-version-of-enzyme-is-released

everett980 · 2019-03-06T05:21:12Z

This PR should get the test coverage up to snuff. It was once 100% for all files in this PR. Now it might be slightly dated so I'll take a look on Thursday.

tiffon

Looks great. Search seems faster.

A handful of small comments.

packages/jaeger-ui/src/components/TraceDiff/TraceDiffGraph/drawNode.js

tiffon · 2019-03-07T02:19:59Z

packages/jaeger-ui/src/components/TraceDiff/TraceDiffGraph/TraceDiffGraph.css

  stroke-width: 1.2;
 }

+.TraceDiffGraph--dag.uiFind {


Because this CSS selector reflects the state of a component, uiFind should be prefixed with is-, e.g. something like .is-uiFind or .is-find-mode.

packages/jaeger-ui/src/components/TraceDiff/TraceDiffGraph/TraceDiffGraph.css

tiffon · 2019-03-07T02:21:49Z

packages/jaeger-ui/src/components/TraceDiff/TraceDiffGraph/TraceDiffGraph.js

-  props: Props;
+export function setOnNodesContainer(state: Object) {
+  const { zoomTransform } = state;
+  const matchSize = 8 + 4 / _get(zoomTransform, 'k', 1);


Seems like these magic numbers could stand to be consts.

packages/jaeger-ui/src/components/TraceDiff/TraceDiffGraph/TraceDiffGraph.js

tiffon · 2019-03-07T03:01:03Z

packages/jaeger-ui/src/utils/span-ancestor-ids.js

+  const ancestors: Span[] = [];
+  let ref = getFirstAncestor(span);
+  while (ref) {
+    ancestors.push(ref);


Seems like you can push the ID in and skip _map(...., 'spanID')

ancestors.push(ref.spanID);

good call, I changed it to a set of IDs (just in case there are repeated IDs) and then converted to an array in the return.
although now I am wondering if it is possible for there to be repeated spanIDs in a trace.

tiffon · 2019-03-07T03:09:32Z

packages/jaeger-ui/src/components/TracePage/index.js

  _searchBar: { current: Input | null };
  _scrollManager: ScrollManager;
+  traceDagEV: Object;


Why make this an object instead of something with { edges: ..., vertices: ... } or direct _edges and _vertices?

if convPlexus's return value was typed, then this and other places could simply import that return value. I started trying to type it but wasn't quite satisfying flow and the errors it gave were not simple to debug. Since we're about to convert to typescript, I'd rather add a todo comment.
// TODO: typescript conversion - use convPlexus return type

tiffon · 2019-03-07T03:11:48Z

packages/jaeger-ui/src/components/TracePage/index.js

@@ -346,10 +306,14 @@ export class TracePageImpl extends React.PureComponent<TracePageProps, TracePage
      return <ErrorMessage className="ub-m3" error={trace.error || 'Unknown error'} />;
    }

+    // $FlowIgnore because flow believes Set<string> cannot be assigned to Set<string | number>
+    const findMatches: Set<string | number> = traceGraphView


If uiFind is empty, then filtering the vertices or spans is unnecessary.

Both of the filter functions that can be called have a default return for falsy uiFind arguments.

packages/jaeger-ui/src/components/TracePage/TracePageHeader/TracePageSearchBar.js

packages/jaeger-ui/src/utils/update-ui-find.js

* Process FOLLOWS_FROM spans in TraceView Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com> * Add test for FOLLOWS_FROM span relation for SpanTreeOffset Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>

Signed-off-by: Everett Ross <reverett@uber.com>

everett980 · 2019-03-08T00:13:52Z

DCO seems to not work whenever master is merged into a branch. Which ever commits exists on master and not my branch fail even though they made it to master somehow.
I manually set DCO to pass because that's an option and it's not my commit that's failing, but I don't understand how this PR has had this issue for numerous commits given that I'm not doing anything abnormal.

…aph' into issue-239-fix-TracePageHeader-tests-once-new-version-of-enzyme-is-released

Signed-off-by: Everett Ross <reverett@uber.com>

…ests-once-new-version-of-enzyme-is-released Update enzyme, Re-enable and add TraceDiff and TracePage tests

tiffon

🎉 The tests look great! 🎉

Some minor comments.

packages/jaeger-ui/src/utils/span-ancestor-ids.js

packages/jaeger-ui/src/components/TraceDiff/TraceDiff.test.js

tiffon · 2019-03-10T21:59:33Z

packages/jaeger-ui/src/components/TraceDiff/TraceDiff.test.js

+      ).toEqual([defaultA, defaultB, ...defaultCohortIds, nonDefaultCohortId]);
+    });
+
+    // This test may false negative if previous tests are failing


Why is this test dependent on previous tests? Seems like setting defaultProps in beforeEach(...) would avoid this.

the test passes in isolation, but if this test and other tests are failing then the other tests should be investigated first as this one encompasses the functionality of simpler tests.

In that case, not sure I'd call it a false negative. If this test and the simpler tests are failing, this test will still fail if run in isolation.

packages/jaeger-ui/src/components/TraceDiff/TraceDiffGraph/TraceDiffGraph.css

packages/jaeger-ui/src/components/TraceDiff/TraceDiffGraph/traceDiffGraphUtils.js

packages/jaeger-ui/src/components/TraceDiff/url.test.js

packages/jaeger-ui/src/components/TraceDiff/TraceDiffHeader/TraceDiffHeader.test.js

packages/jaeger-ui/src/components/TraceDiff/TraceDiffHeader/CohortTable.test.js

Signed-off-by: Everett Ross <reverett@uber.com>

…tracegraph-and-tracediffgraph

Signed-off-by: Everett Ross <reverett@uber.com>

Feedback implemented except for one TODO re types that'll be easier in tyescript

…d-tracediffgraph

tiffon

Awesome work! 🎉

…de-search-to-tracegraph-and-tracediffgraph Move filter to query param and highlight filter matches on graphs Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>

ghost assigned everett980 Jan 9, 2019

ghost added the review label Jan 9, 2019

everett980 requested a review from tiffon January 10, 2019 20:53

tiffon previously requested changes Jan 14, 2019

View reviewed changes

copa2 and others added 22 commits January 16, 2019 16:44

Unfocus unit test (jaegertracing#298)

2baf075

Signed-off-by: Joe Farro <joef@uber.com> Signed-off-by: Everett Ross <reverett@uber.com>

Add ability to search for nodes in TraceDiffGraph and TraceGraph (jae…

07c7f4f

…gertracing#307) Signed-off-by: Everett Ross <reverett@uber.com>

Style GraphSearch, Debounce query param updating

1953db5

Signed-off-by: Everett Ross <reverett@uber.com>

Use hex instead of html colors, remove commented code

e918deb

Signed-off-by: Everett Ross <reverett@uber.com>

Handle falsy graphSearch value in state, improve typing

181562c

Signed-off-by: Everett Ross <reverett@uber.com>

Move GraphSearch and use as utility

edf4805

Signed-off-by: Everett Ross <reverett@uber.com>

Add tests for GraphSearch

d1e05d6

Signed-off-by: Everett Ross <reverett@uber.com>

Add tests for consuming GraphSearch, Add tests for filter-spans

5fa907b

Signed-off-by: Everett Ross <reverett@uber.com>

Improve spy variable name

0122fd7

Signed-off-by: Everett Ross <reverett@uber.com>

Add SpanID support to filter-spans, Consolidate textFilter & GraphSearch

7ea05f4

Signed-off-by: Everett Ross <reverett@uber.com>

Unify uiFind name, fix refs, improve types, remove commented code

2bf1b43

Signed-off-by: Everett Ross <reverett@uber.com>

Add tests to new & tested files, merge common/GraphSearch into user

353d69c

Signed-off-by: Everett Ross <reverett@uber.com>

Update exisitng test files

99b7a6c

Signed-off-by: Everett Ross <reverett@uber.com>

everett980 added 3 commits March 5, 2019 16:22

Clean up CSS, Track only TracePage, Fix span-ancestor-ids logic

15c51d5

Signed-off-by: Everett Ross <reverett@uber.com>

Ensure scroll to bottom scrolls to last visible span

a1f5e59

Signed-off-by: Everett Ross <reverett@uber.com>

Move addToUiFind logic to VirtualizedTraceView

aa3f2e5

Signed-off-by: Everett Ross <reverett@uber.com>

everett980 added 2 commits March 5, 2019 18:50

Merge branch 'master' into issue-307-add-node-search-to-tracegraph-an…

df9bafd

…d-tracediffgraph

Merge branch 'issue-307-add-node-search-to-tracegraph-and-tracediffgr…

7422720

…aph' into issue-239-fix-TracePageHeader-tests-once-new-version-of-enzyme-is-released

tiffon previously requested changes Mar 7, 2019

View reviewed changes

rubenvp8510 and others added 3 commits March 7, 2019 18:54

Process FOLLOWS_FROM spans in TraceView (jaegertracing#335)

c5034fa

* Process FOLLOWS_FROM spans in TraceView Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com> * Add test for FOLLOWS_FROM span relation for SpanTreeOffset Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>

Move graph utils to new file, Clean up span-ancestor-id loop

95026f9

Signed-off-by: Everett Ross <reverett@uber.com>

fix merge again

c3d4d14

Signed-off-by: Everett Ross <reverett@uber.com>

everett980 force-pushed the issue-307-add-node-search-to-tracegraph-and-tracediffgraph branch from 41ebaad to c3d4d14 Compare March 8, 2019 00:10

everett980 requested a review from tiffon March 8, 2019 14:49

everett980 and others added 3 commits March 8, 2019 09:58

Merge branch 'issue-307-add-node-search-to-tracegraph-and-tracediffgr…

bf3386f

…aph' into issue-239-fix-TracePageHeader-tests-once-new-version-of-enzyme-is-released

Update tests after merge

b4afe2d

Signed-off-by: Everett Ross <reverett@uber.com>

Merge pull request #1 from everett980/issue-239-fix-TracePageHeader-t…

de6571f

…ests-once-new-version-of-enzyme-is-released Update enzyme, Re-enable and add TraceDiff and TracePage tests

tiffon reviewed Mar 11, 2019

View reviewed changes

everett980 added 4 commits March 11, 2019 14:00

Clean up and DRY out tests, Change trackFilter to function

5386868

Signed-off-by: Everett Ross <reverett@uber.com>

Merge branch 'jaegertracingmaster' into issue-307-add-node-search-to-…

5971072

…tracegraph-and-tracediffgraph

Fix yarn.lock urls

c5f40c8

Signed-off-by: Everett Ross <reverett@uber.com>

Fix yarn.lock change %2f back to /

8a4b0fb

Signed-off-by: Everett Ross <reverett@uber.com>

Merge branch 'master' into issue-307-add-node-search-to-tracegraph-an…

d3965dc

…d-tracediffgraph

ghost assigned tiffon Mar 12, 2019

tiffon approved these changes Mar 12, 2019

View reviewed changes

tiffon merged commit 2d5edfd into jaegertracing:master Mar 12, 2019

ghost removed the review label Mar 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move filter to query param and highlight filter matches on graphs #310

Move filter to query param and highlight filter matches on graphs #310

everett980 commented Jan 9, 2019 •

edited

Loading

codecov bot commented Jan 9, 2019 •

edited

Loading

tiffon commented Jan 14, 2019 •

edited

Loading

tiffon left a comment

tiffon Jan 14, 2019

everett980 Jan 14, 2019

tiffon Jan 15, 2019

tiffon Jan 14, 2019

tiffon Jan 14, 2019

everett980 Jan 16, 2019

tiffon Jan 14, 2019

everett980 Jan 16, 2019

tiffon Jan 14, 2019

everett980 Jan 16, 2019

everett980 commented Jan 16, 2019

everett980 commented Mar 5, 2019 •

edited

Loading

everett980 commented Mar 6, 2019

tiffon left a comment

tiffon Mar 7, 2019

tiffon Mar 7, 2019

tiffon Mar 7, 2019

everett980 Mar 7, 2019

tiffon Mar 7, 2019

everett980 Mar 7, 2019

tiffon Mar 7, 2019

everett980 Mar 7, 2019

everett980 commented Mar 8, 2019 •

edited

Loading

tiffon left a comment

tiffon Mar 10, 2019

everett980 Mar 11, 2019

tiffon Mar 12, 2019

tiffon left a comment

Move filter to query param and highlight filter matches on graphs #310

Move filter to query param and highlight filter matches on graphs #310

Conversation

everett980 commented Jan 9, 2019 • edited Loading

Which problem is this PR solving?

Short description of the changes

Demo

On initial load with three spanIDs provided:

Add another filter word

After clicking expand all

Clickable SpanIDs

Find in Diff Graph

Finding Gif (old uiFind)

Updated uiFind

Updated uiFind Close Up

Find in Trace Graph

Close Up of Find

codecov bot commented Jan 9, 2019 • edited Loading

Codecov Report

tiffon commented Jan 14, 2019 • edited Loading

tiffon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

everett980 commented Jan 16, 2019

everett980 commented Mar 5, 2019 • edited Loading

everett980 commented Mar 6, 2019

tiffon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

everett980 commented Mar 8, 2019 • edited Loading

tiffon left a comment

Choose a reason for hiding this comment

🎉 The tests look great! 🎉

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tiffon left a comment

Choose a reason for hiding this comment

Awesome work! 🎉

everett980 commented Jan 9, 2019 •

edited

Loading

codecov bot commented Jan 9, 2019 •

edited

Loading

tiffon commented Jan 14, 2019 •

edited

Loading

everett980 commented Mar 5, 2019 •

edited

Loading

everett980 commented Mar 8, 2019 •

edited

Loading