Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline visualization regression #333

Closed
ledor473 opened this issue Feb 21, 2019 · 2 comments · Fixed by #335
Closed

Timeline visualization regression #333

ledor473 opened this issue Feb 21, 2019 · 2 comments · Fixed by #335

Comments

@ledor473
Copy link
Member

ledor473 commented Feb 21, 2019

Requirement - what kind of business use case are you trying to solve?

Visualize traces

Problem - what in Jaeger blocks you from solving the requirement?

I'm not totally sure how but seems like the pull request #297 broke the indentation in the timeline view in some cases.

If I checkout the previous commit in master (ac4f7a7) I see this:
pre

But when I checkout this commit from master (f23eb48) I see this:
post

Here's the trace that is in the screenshot above: https://gist.github.com/ledor473/a51e66aee1f14285eef4953ae7ee6d59

Proposal - what do you suggest to solve the problem or improve the existing situation?

I'm not sure what broke it exactly, so its hard to propose a fix.

@yurishkuro
Copy link
Member

@tiffon @everett980 please take a look

@everett980
Copy link
Collaborator

Thanks for raising!
I have a change to ancestor-ids in this pr
I will verify that it fixes the issue for this trace (it should).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants