-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch Download of traces #663
Comments
I don't know if there is any updated feature about it. However, since I need to download json files in batch now, I wrote this simple script in Python, which did the work for me:
Hope this helps whoever needs batch-export right now. |
The option to simply export/download all found traces of a search to json would be so useful. |
I would like to work on this issue |
It's yours! |
Hi @Joyce-O I was wondering if you made some progress with this feature? I can offer to have a look at your approach and/or do a review. Best, Arne |
Hi @Joyce-O Just following up on my above comment. Did you make some progress, can I assist you somehow? |
I am also looking for export/download feature for all found traces in json format. Is there any update on this feature? Thanks! |
hi @Joyce-O , |
hi @jpkrohling , |
@Katarzyna-B feel free to submit PRs, there is no real value in assigning issues. |
@yurishkuro thx for your answer. I will finish writing tests and after that I will create PR. |
- add a button plus download function, tests (Resolves jaegertracing#663)
- add a button plus download function, tests (Resolves jaegertracing#663)
- add a button plus download function, tests (Resolves jaegertracing#663)
- add a button plus download function, tests (Resolves jaegertracing#663)
- add a button plus download function, tests (Resolves jaegertracing#663)
- Resolves jaegertracing#663 ## Short description of the changes - Add a button with download functionality Signed-off-by: katarzyna <katarzyna@smaato.com>
- Resolves jaegertracing#663 ## Short description of the changes - Add a button with download functionality Signed-off-by: Katarzyna-B <edab@gmx.net>
I am posting here so that people who already subscribe to the issue may provide opinions on the proposed PR #1274. PR adds a button "Download Results" that saves all traces from the search results as one file. I think there are a couple of issues here: Selective downloadOne of the requirements was to select which traces to download. We already have checkboxes next to each trace which when clicked add the traces to a list above the results I think it would make sense to reuse this for selective downloads, by changing the caption from "N selected for comparison" to just "N selected" and adding a Download button on the right, next to Compare Traces Download formatI think another motivation for downloading traces is to be able to upload them back in to the UI. This PR downloads them as a single JSON file, which means they can only be uploaded back into UI as a batch (without extra work on splitting the file). Is that what people would want? The alternative could be to download a single zip file where each trace is a separate file. |
Hi @yurishkuro , Thank you for looking into my PR and posting your comments here. In my PR implementation we have functionality for 'A download traces button in the search view to download all found traces'. What is still missing
I agree that the other requirements are still needed. I like your suggestion regarding Selective download. Download format
It will be great if we can make it configurable and a user can decide if he/she prefers one single file in json format or zip file with traces stored separately. The open question for me is if we want to split the work into small tasks and implement it step by step. What do you think about it? |
@Katarzyna-B fair enough, we can do this piecemeal, starting with full download. I changed the description to contain multiple tasks.
One of the reasons mentioned for downloading traces in the first place is for storing them in tickets for longer time than the retention period in the main trace database. To view those traces again people would upload them back into the UI (see the tab in the Search form). And this is where it could be helpful if the traces were stored as individual files in an archive (although upload should work for a JSON array too). It's more of a nice-to-have functionality (I made a separate subtask for it), could be done by adding a dropdown option to the download button, e.g. like this: |
Hi @yurishkuro and @Katarzyna-B I commented above as one of the last commentators that the download of search results would be really helpful. So I would be happy if the PR from @Katarzyna-B would get merged. That would be extremely helpful already. And maybe a good start for the other two aspects to be worked on. |
Hi @yurishkuro
Thank you. I will check the PR-comments to get the first task already done.
I got your point. I think it is really good idea.
It is good place in case you've already searched for some traces if not you see only the logo on the right side. |
- Resolves jaegertracing#663 ## Short description of the changes - Add a button with download functionality Signed-off-by: katarzyna <katarzyna@smaato.com>
- Resolves jaegertracing#663 ## Short description of the changes - Add a button with download functionality Signed-off-by: katarzyna <katarzyna@smaato.com>
- Resolves jaegertracing#663 ## Short description of the changes - Add a button with download functionality Signed-off-by: katarzyna <katarzyna@smaato.com>
- Resolves jaegertracing#663 ## Short description of the changes - Add a button with download functionality Signed-off-by: katarzyna <katarzyna@smaato.com>
- Resolves jaegertracing#663 ## Short description of the changes - Add a button with download functionality Signed-off-by: katarzyna <katarzyna@smaato.com>
Batch Download of traces ## Which problem is this PR solving? - Resolves #663 ## Short description of the changes - Add a button with download functionality --------- Signed-off-by: katarzyna <katarzyna@smaato.com> Signed-off-by: Máté Szabó <mszabo@fandom.com> Co-authored-by: Máté Szabó <mszabo@fandom.com>
Hi @yurishkuro, I don't see any task regarding the upload/import functionality. In my previous comment I suggested different place for the upload/import button.
what do you think? |
I don't follow. The upload is at the top-left, next to Search. I do think it should be renamed from "JSON File" to "Upload" (maybe also add icons to both Search and Upload) |
- Resolves jaegertracing#663 - fix format of a downloaded json file ## Short description of the changes - fix a format of a downloaded file format to be able to use for uploading back into the UI Signed-off-by: katarzyna <katarzyna@smaato.com>
- Resolves jaegertracing#663 - fix format of a downloaded json file ## Short description of the changes - fix a format of a downloaded file to be able to use for uploading back into the UI Signed-off-by: katarzyna <katarzyna@smaato.com>
Hi @yurishkuro , |
- Resolves jaegertracing#663 - fix format of a downloaded json file ## Short description of the changes - fix a format of a downloaded file to be able to use for uploading back into the UI Signed-off-by: katarzyna <katarzyna@smaato.com>
- Resolves jaegertracing#663 - fix format of a downloaded json file ## Short description of the changes - fix a format of a downloaded file format to be able to use for uploading back into the UI Signed-off-by: katarzyna <katarzyna@smaato.com>
- Part of #663 - fix format of a downloaded json file ## Short description of the changes - fix a format of a downloaded file to be able to use for uploading back into the UI Signed-off-by: katarzyna <katarzyna@smaato.com> --------- Signed-off-by: katarzyna <katarzyna@smaato.com>
Batch Download of traces ## Which problem is this PR solving? - Resolves jaegertracing#663 ## Short description of the changes - Add a button with download functionality --------- Signed-off-by: katarzyna <katarzyna@smaato.com> Signed-off-by: Máté Szabó <mszabo@fandom.com> Co-authored-by: Máté Szabó <mszabo@fandom.com>
- Part of jaegertracing#663 - fix format of a downloaded json file ## Short description of the changes - fix a format of a downloaded file to be able to use for uploading back into the UI Signed-off-by: katarzyna <katarzyna@smaato.com> --------- Signed-off-by: katarzyna <katarzyna@smaato.com>
- Part of jaegertracing#663 - fix format of a downloaded json file ## Short description of the changes - fix a format of a downloaded file to be able to use for uploading back into the UI Signed-off-by: katarzyna <katarzyna@smaato.com> --------- Signed-off-by: katarzyna <katarzyna@smaato.com> Signed-off-by: RAMU MANAM <manam.ramu@uber.com>
Requirement - what kind of business use case are you trying to solve?
Our traces contain data that is covered by GDPR (european user privacy regulations) and, thus developers do not have direct access to all traces. If an error occurs, relevant traces has to be filtered out and the relevant ones are forwarded to the developer.
Another use case:
It would be nice to just attach files with relevant traces to a Jira Ticket. HTTP Links are nice but they are are only available for a certain time, which conflicts with some of our documentation requirements, and everybody has to have access to the jaeger instance.
Problem - what in Jaeger blocks you from solving the requirement?
The process of "exporting" the traces is cumbersome. For each trace, you have to go to the json view and save it.
Proposal - what do you suggest to solve the problem or improve the existing situation?
It would be nice to have:
The text was updated successfully, but these errors were encountered: