Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching spans in a trace page doesn't work #803

Closed
RotemKir opened this issue Aug 26, 2021 · 7 comments · Fixed by #837
Closed

Searching spans in a trace page doesn't work #803

RotemKir opened this issue Aug 26, 2021 · 7 comments · Fixed by #837

Comments

@RotemKir
Copy link

Describe the bug
Open a specific trace and enter a span id in the "Find..." textbox does nothing.

To Reproduce
Steps to reproduce the behavior:

  1. Open a trace in jaeger ui.
  2. Enter a span id in the "Find..." textbox.
  3. The url in the browser is updated with the "uiFind=..." parameter but the relevant span isn't marked or found.
  4. Refreshing the screen or navigating to the updated url finds the span.
  5. No errors were shown in the browser dev tools console, no http errors or calls were made.

Expected behavior
When searching a span id the span should be marked and found (nice to have: a message if nothing was found).

Screenshots
Entering span id (nothing happens):
Screenshot 2021-08-26 091009

Refreshing the screen with the same url:
Screenshot 2021-08-26 091229

Version (please complete the following information):

  • OS: Windows (for the browser), linux for the jaeger backend
  • Jaeger version: all-in-one 1.25.0, jaeger UI version 1.15.0
  • Deployment: local docker (docker desktop) or in kubernetes

What troubleshooting steps did you try?

  1. Didn't see any errors in the dev tools console.
  2. Didn't see any http calls (should be fine I guess since the search is probably done in the client side).
  3. Couldn't find any existing issue open in github related to this.

Additional context
IIRC the search worked fine a few versions earlier, can't recall which version since I upgraded the docker image several times in the past month.
As a workaround refreshing the screen or navigating directly to the url with the trace and span ids works, just searching in the page seems broken.

@RotemKir RotemKir added the bug label Aug 26, 2021
@ndrscodes
Copy link

@RotemKir Can confirm in 1.25.0, the issue is also present in jaeger 1.24.0.

@ndrscodes
Copy link

I am a backend dev so i really have no real clue about react, but i'm pretty sure focusSpan() is never actually called and the span query is never updated. Passing the uiFind parameter in the URL unlocks the search menu buttons on the side, but once you use them, the input on the side is reset to the previously found span ID.
Maybe that helps someone with react experience fix the issue :)

@w0wka91
Copy link
Contributor

w0wka91 commented Oct 14, 2021

I will take a look at this bug if thats okay with you guys?!
Or is someone else already working on this issue?

@albertteoh
Copy link
Contributor

Yup, I'm able to reproduce with the latest build as well.

No one has claimed this so it's yours, @w0wka91 :)

@w0wka91
Copy link
Contributor

w0wka91 commented Oct 23, 2021

The problem is related to incompatible versions of react-router-redux and react-router-dom.
At the moment we are using react-router-dom 5.2.0 which is not compatible with react-router-redux 5.x (https://www.npmjs.com/package/react-router-redux/v/5.0.0-alpha.8)
I was able to fix the problem by downgrading react-router-dom to 4.3.1

w0wka91 added a commit to w0wka91/jaeger-ui that referenced this issue Oct 23, 2021
Signed-off-by: Waldemar Penner <waldemar.penner91@gmail.com>
w0wka91 added a commit to w0wka91/jaeger-ui that referenced this issue Oct 23, 2021
Signed-off-by: Waldemar Penner <waldemar.penner91@gmail.com>
@vvvprabhakar
Copy link
Contributor

Any update on this ?

@yurishkuro
Copy link
Member

being addressed in #837

jpkrohling pushed a commit that referenced this issue Nov 30, 2021
* Downgrade react-router-dom (#803)

Signed-off-by: Waldemar Penner <waldemar.penner91@gmail.com>

* Update Snapshots (#803)

Signed-off-by: Waldemar Penner <waldemar.penner91@gmail.com>

Co-authored-by: Ruben Vargas <ruben.vp8510@gmail.com>
yurishkuro pushed a commit that referenced this issue Sep 27, 2023
## Which problem is this PR solving?
- part of: #1825
- Upgrades react-router-dom to v5.2.0

## Description of the changes
- This PR upgrades the rrd to v5.2.0
- This upgrade was previously attempted with PR
#727 but at that time, an
issue (#803) was
reported because `react-router-redux` v5.x was not compatible with rrd
v5.2.0, so it was reverted with PR:
#837
- Now, since we have `redux-first-history` instead of
`react-router-redux`, we can upgrade to rrd v5.2.0 safely now.

## How was this change tested?
- The reported issue with v5.2.0
(#803) is not being
reproduced now.


![image](https://github.com/jaegertracing/jaeger-ui/assets/94157520/43c11ec6-02e6-4ede-855b-22822f77d4ae)


## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants