Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browser prompt error #92

Closed
Luncher opened this issue Oct 13, 2017 · 1 comment
Closed

browser prompt error #92

Luncher opened this issue Oct 13, 2017 · 1 comment
Labels
bug

Comments

@Luncher
Copy link

Luncher commented Oct 13, 2017

Description

Steps to reproduce the issue:

  1. open http://localhost:16686/search
  2. open terminal

Describe the results you received:

Describe the results you expected:

Additional information you deem important (e.g. issue happens only occasionally):

Additional environment details (Browser, etc.):
1507875956028
@tiffon
Copy link
Member

tiffon commented Oct 16, 2017

This looks like the UI is not handling the scenario when there are no known services. That's probably the case when there aren't any traces.

Has this persisted after adding traces?

Thanks for reporting.

@tiffon tiffon added the bug label Oct 16, 2017
tiffon added a commit that referenced this issue Oct 27, 2017
@tiffon
Fix #92 browser prompt error
53e9a92 
Services default to null when no traces have been encountered. Instead,
use an empty array.

Signed-off-by: Joe Farro <joef@uber.com>
@tiffon tiffon mentioned this issue Oct 27, 2017
Merged
tiffon added a commit that referenced this issue Oct 27, 2017
@tiffon
Merge pull request #109 from jaegertracing/issue-92-browser-prompt-error
01fd7f4 
Fix #92 browser prompt error
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this issue Jul 5, 2021
@tiffon
Fix jaegertracing#92 browser prompt error
eddba40 
Services default to null when no traces have been encountered. Instead,
use an empty array.

Signed-off-by: Joe Farro <joef@uber.com>

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this issue Jul 5, 2021
@tiffon
Merge pull request jaegertracing#109 from jaegertracing/issue-92-brow…
a9e3a7b 
…ser-prompt-error

Fix jaegertracing#92 browser prompt error
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tiffon @Luncher