Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instructions notify in Monitor Tab is undefined #928

Closed
FingerLiu opened this issue Apr 13, 2022 · 1 comment · Fixed by #929
Closed

instructions notify in Monitor Tab is undefined #928

FingerLiu opened this issue Apr 13, 2022 · 1 comment · Fixed by #929
Labels

Comments

@FingerLiu
Copy link

Describe the bug
Link in "No data yet! Please see these instructions on how to set up your span metrics." is undefined.

To Reproduce
Steps to reproduce the behavior:

  1. upgrade ui to 1.22
  2. switch to monitor tab
  3. click instructions on the top

Expected behavior
A link to instructions to setup otel

Screenshots
image

Version (please complete the following information):

  • OS: Linux
  • Jaeger version: 1.23
  • Deployment:Kubernetes
@FloydJohn
Copy link
Contributor

FloydJohn commented Apr 13, 2022

On my deployment the link targets https//www.jaegertracing.io/docs/latest/spm/ (notice the lack of : between https and //).

The issue is related to react router treating this link as an internal one, I just opened a PR to fix this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants